Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aMule does not support HTTPS #197

Open
IAmTheNail opened this issue Jun 7, 2020 · 2 comments · May be fixed by #218
Open

aMule does not support HTTPS #197

IAmTheNail opened this issue Jun 7, 2020 · 2 comments · May be fixed by #218
Milestone

Comments

@IAmTheNail
Copy link

For some time now I'm getting this error message whenever amule needs an http connection. As of now it is unable to download any update, server list, ...

It happens with 2.3.2-2 release for ubuntu. Building from source yields the same results.

The error message is raised in HTTPDownload.cpp, line 336

if (!location.StartsWith(wxT("http://"))) {
		// This is not a http url
		throw wxString(_("Invalid URL for HTTP download or HTTP redirection (did you forget 'http://' ?)"));
}

It seems wxT("http://") doesn't result in "http://" anymore. No doubt because of something I did recently on the system. However, I have been unable to find the culprit. Neither can I suggest a workaround because I am not proficient in C++ and the related toolkits.

Btw, is there a special reason to use http only ? That is, not using https.

@IAmTheNail
Copy link
Author

Is it possible amule does not support http redirection ?

.2020-06-07 15:07:18: HTTPDownload.cpp(196): HTTP: HTTP download thread started
.2020-06-07 15:07:18: HTTPDownload.cpp(220): HTTP: If-Modified-Since: Sat, 30 May 2020 18:40:28 GMT
2020-06-07 15:07:18: ServerConnect.cpp(201): Connected to eMule Security (80.208.228.241:8369)
.2020-06-07 15:07:18: HTTPDownload.cpp(392): HTTP: Host: upd.emule-security.org:80
.2020-06-07 15:07:18: HTTPDownload.cpp(393): HTTP: URL: http://upd.emule-security.org/ipfilter.zip
.2020-06-07 15:07:18: HTTPDownload.cpp(394): HTTP: Response: 301 (Error: 0)
.2020-06-07 15:07:18: HTTPDownload.cpp(304): HTTP: HTTP download thread ended
!2020-06-07 15:07:18: HTTPDownload.cpp(292): Invalid URL for HTTP download or HTTP redirection (did you forget 'http://' ?)

@gonosztopi
Copy link
Member

Is it possible amule does not support http redirection ?

It's aMule not supporting HTTPS. The old HTTP URL is now getting redirected to a HTTPS URL, which is not supported (yet).

@gonosztopi gonosztopi changed the title Invalid URL for HTTP download or HTTP redirection (did you forget 'http://' ?) aMule does not support HTTPS Jun 14, 2020
@gonosztopi gonosztopi added this to the v2.3.3 milestone Aug 12, 2020
@gonosztopi gonosztopi linked a pull request Oct 2, 2020 that will close this issue
5 tasks
@gonosztopi gonosztopi linked a pull request Oct 2, 2020 that will close this issue
5 tasks
@gonosztopi gonosztopi modified the milestones: v2.3.3, v2.3.4 Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants