From 8355fce1b51699dddf5a544bffaaeb5fc18e8d30 Mon Sep 17 00:00:00 2001 From: Andre-3rd-Viking Date: Sun, 7 Jul 2024 12:59:57 -0400 Subject: [PATCH] feat: bad examples --- .../src/anti-patterns-examples.ts | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 coding-guide-helper/src/anti-patterns-examples.ts diff --git a/coding-guide-helper/src/anti-patterns-examples.ts b/coding-guide-helper/src/anti-patterns-examples.ts new file mode 100644 index 0000000..5d68696 --- /dev/null +++ b/coding-guide-helper/src/anti-patterns-examples.ts @@ -0,0 +1,20 @@ +// This code uses multiple comparisons in a single if statement +export const antiPatternExample_01 = (value: string) => { + if (value === 'a' || value === 'b' || value === 'c') { + console.log('Value is a, b, or c') + } else { + console.log('Value is something else') + } +} + +// This code should use Array.some() for a more readable and concise solution +export const antiPatternExample_02 = (value: string) => { + const items = [ + { id: 1, name: 'Alice', isActive: false }, + { id: 2, name: 'Bob', isActive: false }, + { id: 3, name: 'Charlie', isActive: true }, + ] + + const activeItems = items.find((item) => item.isActive) !== undefined + console.info('====>>> info', activeItems) +}