library: jesd204: Fixup Vivado exiting with error #1243
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of the create_xgui_files causes Vivado to exit with an error when running multiple Vivado instances (parallel make case) Signed-off-by: Jorge Marques <jorge.marques@analog.com>
acostina
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The lack of the create_xgui_files causes Vivado to exit with an error when running
multiple Vivado instances (parallel make case).
jesd204_commonwas missing this tcl command.To reproduce
Fails on main, but not with the fix.
Important: the ip.log between branches are identical, the only difference is that
Vivado exists with an error code at main.
Tested with Vivado 2022.2 and 2023.1.
PR Type
PR Checklist