Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

API v2 support #16

Open
weppos opened this issue Mar 28, 2018 · 6 comments
Open

API v2 support #16

weppos opened this issue Mar 28, 2018 · 6 comments

Comments

@weppos
Copy link
Contributor

weppos commented Mar 28, 2018

I see this client is currently using API v1. API v1 will be shut down at the end of May.

I don't have the knowledge or resources to provide a PR, but I'll be more than happy to assist if you have any questions about API v2.

For curiosity, do you have any plan to support API v2?

@anderly
Copy link
Owner

anderly commented Apr 11, 2018

@weppos My initial thought is I don't think we'll plan on supporting API v2. With's DNSimple move to OpenAPI spec via Swagger Editor, this should make generating an API client easier without needing to hand-code a custom c# client and keep it in sync with an evolving API. I'm going to try this to see what kind of client can be generated (if any). If it's sufficient, I'll share it here in the repo somehow. Otherwise, I'll evaluate whether it makes sense to try to modify this package to work with v2 of the API.

@weppos
Copy link
Contributor Author

weppos commented Apr 11, 2018

Thanks for the feedback. Yes, we integrated OpenAPI and one of the goal was to be able to take advantage of the various tools built around the specs.

I don't have enough knowledge of C# to judge the result of a C# generated client, hence I'd be more than happy to get your feedback there.

@anderly
Copy link
Owner

anderly commented Apr 11, 2018

@weppos thanks. Sorry, I just realized you work for Dnsimple. I was looking into autorest to see what kind of generated c# client it would provide. Looks like it doesn't yet support OpenAPI 3.0, but it's on their issues list.

I'm looking to see if there's another generator out there that works with the 3.0 spec. Do you happen to have a 2.0 spec or the Swagger 2.0 file I could try with autorest or another generator library?

@weppos
Copy link
Contributor Author

weppos commented Apr 11, 2018

Do you happen to have a 2.0 spec or the Swagger 2.0 file I could try with autorest or another generator library?

Sadly not. We went directly with v3.

@anderly
Copy link
Owner

anderly commented Apr 11, 2018

Ok, I'll keep looking for a good option for a c# generator that supports 3.0 and I'll keep my eye on autorest for when they add support.

Ciao!

@douyoung
Copy link

You may want to try the following instead, which supports both OpenAPI 2.0 and 3.0:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants