Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The locking is done incorrectly is PePuRunner #2

Open
suutari-ai opened this issue Oct 11, 2019 · 0 comments · May be fixed by #3
Open

The locking is done incorrectly is PePuRunner #2

suutari-ai opened this issue Oct 11, 2019 · 0 comments · May be fixed by #3
Labels
bug Something isn't working

Comments

@suutari-ai
Copy link
Member

The PePuRunner class creates a new lock for each instance in the __init__ so it won't really protect two different instances accessing the resources at the same time. This could be a problem if two different events are being handled at the same time.
@suutari-ai suutari-ai added the bug Something isn't working label Oct 11, 2019
@suutari-ai suutari-ai linked a pull request Oct 13, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix locking issue and optimize a bit suutari-ai/pepubot
1 participant
@suutari-ai