Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract extensions from frontend-dynamic-style-sheet into a separate module #12

Open
andrew-k-21-12 opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@andrew-k-21-12
Copy link
Owner

andrew-k-21-12 commented Sep 17, 2024

The extensions package from the frontend-dynamic-style-sheet module contains only quite small and independent extensions. Consider extracting them into a separate utility module.

The biggest question here is whether to treat ElementType<P>.invoke extensions as a part of the front-end core or not. If it will be moved to utility, frontend-dynamic-style-sheet can add the org.jetbrains.kotlin-wrappers:kotlin-css dependency in the api mode (so it won't be needed to add any dependencies explicitly to construct styles for dynamic style sheets). Possibly some other front-end libraries can expose their dependencies in the api mode as well.

@andrew-k-21-12 andrew-k-21-12 added the enhancement New feature or request label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant