Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Settings.alwaysDisplayTabsMode to Settings.setDefaultTabPlacement #162

Open
andrewauclair opened this issue Dec 20, 2023 · 0 comments
Open

Rename Settings.alwaysDisplayTabsMode to Settings.setDefaultTabPlacement #162

andrewauclair opened this issue Dec 20, 2023 · 0 comments
Milestone
0.12.0

Comments

@andrewauclair
Copy link
Owner

Rename this function to be more accurate and more flexible. Right now it sets the tab placement to top and this cannot be changed back to bottom without restarting the application.
@andrewauclair andrewauclair added this to the 0.12.0 milestone Jul 3, 2024
andrewauclair added a commit that referenced this issue Jul 3, 2024
@andrewauclair
Issue #162
e1e51a3 
Replace Settings.alwaysDisplayTabsMode(Dockable) and Settings.setAlwaysDisplayTabMode with Settings.defaultTabPreference and Settings.setDefaultTabPreference.

This new setting makes it possible to specify tab location preference as top or bottom. It also makes it possible to always display tabs by using DockableTabPreference.TOP_ALWAYS and DockableTabPreference.BOTTOM_ALWAYS.

The Dockable.getTabPosition method has been replaced with Dockable.getTabPreference, which now returns an instance of DockableTabPreference and returns NONE by default.
andrewauclair added a commit that referenced this issue Jul 5, 2024
@andrewauclair
Issue #162 (#235)
209651d 
Replace Settings.alwaysDisplayTabsMode(Dockable) and Settings.setAlwaysDisplayTabMode with Settings.defaultTabPreference and Settings.setDefaultTabPreference.

This new setting makes it possible to specify tab location preference as top or bottom. It also makes it possible to always display tabs by using DockableTabPreference.TOP_ALWAYS and DockableTabPreference.BOTTOM_ALWAYS.

The Dockable.getTabPosition method has been replaced with Dockable.getTabPreference, which now returns an instance of DockableTabPreference and returns NONE by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@andrewauclair