Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RootDockingPanelAPI Internal Methods #179

Open
andrewauclair opened this issue Jan 1, 2024 · 1 comment
Open

RootDockingPanelAPI Internal Methods #179

andrewauclair opened this issue Jan 1, 2024 · 1 comment
Labels
fixed Issue has been fixed, pending release.
Milestone
0.12.0

Comments

@andrewauclair
Copy link
Owner

Most of the methods in RootDockingPanelAPI are intended to be internal to the framework. Some thought will have to be given to how these can be made internal. Most likely by moving them to a private class in a package not exported from the module.

User facing:

  • getWindow
  • setEmptyPanel
  • isPiningSupported (renaming to isAutoHideSupported)
  • setPinningSupported (renaming to setAutoHideSupported)
  • getPinningLayer (renaming to getAutoHideLayer)
  • setPinningLayer (renaming to setPinningLayer)

Internal:

  • setWindow
  • getPanel
  • isEmpty
  • setPanel
  • removeExistingPanel
  • dock
  • undock
  • replaceChild
  • removeChild
  • setDockableShown
  • setDockableHidden
  • hiddenPersistentIDs
  • hideHiddenPanels
  • getWestAutoHideToolbarIDs
  • getEastAutoHideToolbarIDs
  • getSouthAutoHideToolbarIDs
  • isLocationSupported
  • updateLAF
@andrewauclair
Copy link
Owner Author

One solution might be to wrap RootDockingPanel in an internal panel and move all the internal methods to that internal panel class.

andrewauclair added a commit that referenced this issue Jul 3, 2024
@andrewauclair
Issue #179
bdffd14 
Creating a new InternalRootDockingPanel and moving most of the methods from RootDockingPanelAPI to it.

RootDockingPanelAPI extends JPanel instead of DockingPanel now.

No deprecation warning is being given for this change because all of these methods were already considered internal, but not explicitly documented as such.
@andrewauclair andrewauclair added this to the 0.12.0 milestone Jul 3, 2024
andrewauclair added a commit that referenced this issue Jul 5, 2024
@andrewauclair
Issue #179 (#234)
366c69d 
Creating a new InternalRootDockingPanel and moving most of the methods from RootDockingPanelAPI to it.

RootDockingPanelAPI extends JPanel instead of DockingPanel now.

No deprecation warning is being given for this change because all of these methods were already considered internal, but not explicitly documented as such.
@andrewauclair andrewauclair added the fixed Issue has been fixed, pending release. label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Issue has been fixed, pending release.
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@andrewauclair