Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released version of prost-reflect contains binary data #137

Open
weiznich opened this issue Dec 17, 2024 · 0 comments · May be fixed by #138
Open

Released version of prost-reflect contains binary data #137

weiznich opened this issue Dec 17, 2024 · 0 comments · May be fixed by #138

Comments

@weiznich
Copy link

The current released version (0.14.3) of prost-reflect uploaded to crates.io contains binary data. This is not desirable as it's hard to review these data for correctness. Additionally such binary data might be the starting point of a supply chain attack similar to what happened with the xz library earlier this year.

https://diff.rs/prost-reflect/0.14.2/0.14.3

I can see binary data at least in

  • src/well_known_types.bin
  • doc/file_descriptor_set.bin

In this particular case it seems like the binary data contain protobuf file descriptors, which might be useful in certain cases. Nevertheless it would be desirable to not include them by for the reasons outlined above explicitly excluding in your Cargo.toml file:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant