Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle closed enums #44

Open
3 tasks
andrewhickman opened this issue May 26, 2023 · 0 comments
Open
3 tasks

Handle closed enums #44

andrewhickman opened this issue May 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@andrewhickman
Copy link
Owner

In proto2, unknown values for enums are handled differently to proto3: https://protobuf.dev/programming-guides/enum/

  • Closed enums (defined in proto2) should be parsed into unknown fields if the value is unknown
  • We should add an is_closed() API to enums to make this behaviour documentable
  • Validate that closed enums cannot be used in proto3 messages (Validation of FileDescriptorSets #5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewhickman