Skip to content

Commit c82d8e0

Browse files
authored
Merge pull request #182 from android/riggaroo/remove-screenshot-testing
Update Deps + Remove screenshot testing plugin until it works with newer versions of Gradle plugin
2 parents b284091 + fc68df6 commit c82d8e0

File tree

9 files changed

+24
-52
lines changed

9 files changed

+24
-52
lines changed

.github/workflows/build_and_test.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ jobs:
6060
- name: Build debug APK
6161
run: ./gradlew assembleDebug --no-configuration-cache
6262

63-
- name: Verify Screenshot Tests (AndroidX)
64-
run: ./gradlew validateDebugScreenshotTest
65-
6663
- name: Run local unit tests
6764
run: ./gradlew testDebugUnitTest
6865

core/theme/src/main/java/com/android/developers/androidify/theme/Motion.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ import androidx.compose.ui.geometry.Rect
2929
)
3030
val MotionScheme.sharedElementTransitionSpec: BoundsTransform
3131
@Composable
32-
get() = object : BoundsTransform {
33-
override fun transform(
34-
initialBounds: Rect,
35-
targetBounds: Rect,
36-
): FiniteAnimationSpec<Rect> {
37-
return this@sharedElementTransitionSpec.slowSpatialSpec()
38-
}
32+
get() = BoundsTransform { _, _ ->
33+
this@sharedElementTransitionSpec.slowSpatialSpec()
3934
}

core/theme/src/main/java/com/android/developers/androidify/theme/SharedElementsConfig.kt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,7 @@ val LocalAnimateBoundsScope = compositionLocalOf<LookaheadScope?> {
8787
)
8888
val MotionScheme.sharedElementTransitionBounds: BoundsTransform
8989
@Composable
90-
get() = object : BoundsTransform {
91-
override fun transform(
92-
initialBounds: Rect,
93-
targetBounds: Rect,
94-
): FiniteAnimationSpec<Rect> {
95-
return sharedElementTransitionSpec()
96-
}
97-
}
90+
get() = BoundsTransform { _, _ -> sharedElementTransitionSpec() }
9891

9992
fun <T> MotionScheme.sharedElementTransitionSpec(): FiniteAnimationSpec<T> {
10093
return tween(600)

feature/camera/build.gradle.kts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ plugins {
1919
alias(libs.plugins.kotlin.compose)
2020
alias(libs.plugins.kotlin.ksp)
2121
alias(libs.plugins.hilt)
22-
alias(libs.plugins.composeScreenshot)
2322
}
2423

2524
android {
@@ -42,8 +41,6 @@ android {
4241
compose = true
4342
}
4443

45-
experimentalProperties["android.experimental.enableScreenshotTest"] = true
46-
4744
testOptions {
4845
targetSdk = 36
4946
}
@@ -95,5 +92,6 @@ dependencies {
9592
kspAndroidTest(libs.hilt.compiler)
9693

9794
debugImplementation(libs.androidx.ui.test.manifest)
98-
screenshotTestImplementation(libs.androidx.ui.tooling)
95+
// Disable until it works with newer Gradle versions
96+
// screenshotTestImplementation(libs.androidx.ui.tooling)
9997
}

feature/creation/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ plugins {
1919
alias(libs.plugins.kotlin.compose)
2020
alias(libs.plugins.kotlin.ksp)
2121
alias(libs.plugins.hilt)
22-
alias(libs.plugins.composeScreenshot)
2322
}
2423

2524
android {
@@ -44,8 +43,6 @@ android {
4443
compose = true
4544
}
4645

47-
experimentalProperties["android.experimental.enableScreenshotTest"] = true
48-
4946
testOptions {
5047
unitTests {
5148
isIncludeAndroidResources = true

feature/home/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ plugins {
1919
alias(libs.plugins.kotlin.compose)
2020
alias(libs.plugins.kotlin.ksp)
2121
alias(libs.plugins.hilt)
22-
alias(libs.plugins.composeScreenshot)
2322
}
2423

2524
android {
@@ -42,8 +41,6 @@ android {
4241
compose = true
4342
}
4443

45-
experimentalProperties["android.experimental.enableScreenshotTest"] = true
46-
4744
testOptions {
4845
targetSdk = 36
4946
}

feature/results/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ plugins {
1919
alias(libs.plugins.kotlin.compose)
2020
alias(libs.plugins.kotlin.ksp)
2121
alias(libs.plugins.hilt)
22-
alias(libs.plugins.composeScreenshot)
2322
}
2423

2524
android {
@@ -43,8 +42,6 @@ android {
4342
compose = true
4443
}
4544

46-
experimentalProperties["android.experimental.enableScreenshotTest"] = true
47-
4845
testOptions {
4946
targetSdk = 36
5047
}

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ kotlin.code.style=official
2525
android.nonTransitiveRClass=true
2626
android.disableMinifyLocalDependenciesForLibraries=true
2727
org.gradle.configuration-cache=true
28-
android.experimental.enableScreenshotTest=true
28+
android.experimental.enableScreenshotTest=false

gradle/libs.versions.toml

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
appVersionCode = "10"
44
appVersionName = "1.3.0"
55
appVersionWearOffset = "60000000"
6-
agp = "8.12.0"
7-
bcpkixJdk18on = "1.82"
6+
agp = "8.13.1"
7+
bcpkixJdk18on = "1.83"
88
compileSdk = "36"
99
core = "1.7.0"
1010
extensionsXr = "1.1.0"
@@ -16,17 +16,16 @@ wearMinSdk = "36"
1616

1717
#dependencies
1818
accompanist = "0.37.3"
19-
activityCompose = "1.11.0"
20-
adaptive = "1.1.0"
21-
animationAndroid = "1.9.3"
19+
activityCompose = "1.12.1"
20+
adaptive = "1.2.0"
2221
apksig = "9.0.0-alpha06"
2322
appcompat = "1.7.1"
2423
baselineprofile = "1.4.1"
2524
benchmarkMacroJunit4 = "1.4.1"
26-
camerax = "1.5.1"
25+
camerax = "1.5.2"
2726
coilCompose = "3.3.0"
2827
coilGif = "3.3.0"
29-
composeBom = "2025.10.00"
28+
composeBom = "2025.12.00"
3029
concurrent = "1.3.0"
3130
converterGson = "2.11.0"
3231
coreKtx = "1.17.0"
@@ -46,19 +45,19 @@ hiltNavigationCompose = "1.3.0"
4645
horologist = "0.7.15"
4746
junit = "4.13.2"
4847
junitVersion = "1.3.0"
49-
kotlin = "2.2.0"
50-
ksp = "2.2.0-2.0.2"
48+
kotlin = "2.2.21"
49+
ksp = "2.2.20-2.0.3"
5150
kotlinxCoroutines = "1.10.2"
52-
kotlinxSerialization = "2.2.20"
51+
kotlinxSerialization = "2.2.21"
5352
kotlinxSerializationJson = "1.9.0"
5453
kotlinxSerializationProtobuf = "1.9.0"
5554
ktlint = "1.5.0"
56-
lifecycleRuntimeKtx = "2.9.4"
55+
lifecycleRuntimeKtx = "2.10.0"
5756
lifecycleViewmodelNavigation3 = "1.0.0-alpha04"
58-
loggingInterceptor = "5.2.1"
59-
material = "1.12.0"
57+
loggingInterceptor = "5.3.2"
58+
material3 = "1.5.0-alpha10"
6059
media3 = "1.8.0"
61-
navigation3 = "1.0.0-alpha11"
60+
navigation3 = "1.0.0"
6261
okhttp = "4.12.0"
6362
playServicesWearable = "19.0.0"
6463
playServicesBaseTesting = "16.2.0"
@@ -70,8 +69,8 @@ spotless = "8.0.0"
7069
startup = "1.2.0"
7170
runner = "1.7.0"
7271
uiTextGoogleFonts = "1.9.3"
73-
uiautomator = "2.4.0-alpha06"
74-
uiTooling = "1.9.3"
72+
uiautomator = "2.4.0-alpha07"
73+
uiTooling = "1.10.0"
7574
validatorPush = "1.0.0-alpha08"
7675
watchFacePush = "1.0.0-alpha01"
7776
wear = "1.3.0"
@@ -93,14 +92,14 @@ androidx-activity-compose = { group = "androidx.activity", name = "activity-comp
9392
androidx-adaptive = { module = "androidx.compose.material3.adaptive:adaptive", version.ref = "adaptive" }
9493
androidx-adaptive-layout = { module = "androidx.compose.material3.adaptive:adaptive-layout", version.ref = "adaptive" }
9594
androidx-adaptive-navigation = { module = "androidx.compose.material3.adaptive:adaptive-navigation", version.ref = "adaptive" }
96-
androidx-animation-android = { group = "androidx.compose.animation", name = "animation-android", version.ref = "animationAndroid" }
95+
androidx-animation-android = { group = "androidx.compose.animation", name = "animation-android" }
9796
androidx-appcompat = { group = "androidx.appcompat", name = "appcompat", version.ref = "appcompat" }
9897
androidx-app-startup = { group = "androidx.startup", name = "startup-runtime", version.ref = "startup" }
9998
androidx-camera-camera2 = { module = "androidx.camera:camera-camera2", version.ref = "camerax" }
10099
androidx-camera-compose = { module = "androidx.camera:camera-compose", version.ref = "camerax" }
101100
androidx-camera-core = { module = "androidx.camera:camera-core", version.ref = "camerax" }
102101
androidx-camera-lifecycle = { group = "androidx.camera", name = "camera-lifecycle", version.ref = "camerax" }
103-
androidx-compose-bom = { group = "androidx.compose", name = "compose-bom-alpha", version.ref = "composeBom" }
102+
androidx-compose-bom = { group = "androidx.compose", name = "compose-bom", version.ref = "composeBom" }
104103
androidx-concurrent-futures-ktx = { module = "androidx.concurrent:concurrent-futures-ktx", version.ref = "concurrent" }
105104
androidx-core = { module = "androidx.test:core", version.ref = "core" }
106105
androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "coreKtx" }
@@ -113,7 +112,7 @@ androidx-junit = { group = "androidx.test.ext", name = "junit", version.ref = "j
113112
androidx-lifecycle-runtime-ktx = { group = "androidx.lifecycle", name = "lifecycle-runtime-ktx", version.ref = "lifecycleRuntimeKtx" }
114113
androidx-lifecycle-viewmodel-ktx = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "lifecycleRuntimeKtx" }
115114
androidx-lifecycle-viewmodel-navigation3 = { module = "androidx.lifecycle:lifecycle-viewmodel-navigation3", version.ref = "lifecycleViewmodelNavigation3" }
116-
androidx-material3 = { group = "androidx.compose.material3", name = "material3" }
115+
androidx-material3 = { group = "androidx.compose.material3", name = "material3", version.ref = "material3" }
117116
androidx-media3-exoplayer = { group = "androidx.media3", name = "media3-exoplayer", version.ref = "media3" }
118117
androidx-media3-ui = { group = "androidx.media3", name = "media3-ui", version.ref = "media3" }
119118
androidx-media3-ui-compose = { group = "androidx.media3", name = "media3-ui-compose", version.ref = "media3" }
@@ -198,5 +197,4 @@ kotlin-ksp = { id ="com.google.devtools.ksp", version.ref = "ksp" }
198197
serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlinxSerialization" }
199198
android-test = { id = "com.android.test", version.ref = "agp" }
200199
baselineprofile = { id = "androidx.baselineprofile", version.ref = "baselineprofile" }
201-
composeScreenshot = { id = "com.android.compose.screenshot", version = "0.0.1-alpha10" }
202200
spotless = { id = "com.diffplug.spotless", version.ref = "spotless" }

0 commit comments

Comments
 (0)