Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Multi language support? #331

Open
XinyueZ opened this issue Feb 12, 2019 · 4 comments
Open

Multi language support? #331

XinyueZ opened this issue Feb 12, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@XinyueZ
Copy link
Contributor

XinyueZ commented Feb 12, 2019 •
edited
Loading

The project has now
S-Chinese
T-Chinese
Japanese #322
German #337
Italian #341
English

Can people add an extra one or more language support?
@tiembo
Copy link
Contributor

tiembo commented Feb 12, 2019

Absolutely! Some good candidates:

  • German (longer strings)
  • RTL language(s)

@tiembo tiembo added enhancement New feature or request help wanted Extra attention is needed labels Feb 12, 2019
@andhie
Copy link
Contributor

andhie commented Feb 13, 2019

i suppose the assets/plants.json should also be translated?

@tiembo
Copy link
Contributor

tiembo commented Feb 13, 2019

@andhie that would be ideal but it's a large undertaking and is a very low priority for this sample project.

@YassinAJDI YassinAJDI mentioned this issue Jun 17, 2019
Open
@YassinAJDI
Copy link

@tiembo I have added support for Arabic language on this PR #430

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tiembo @andhie @XinyueZ @YassinAJDI and others