where is submid_record in the ChangeInfo

[Ai-feier]

[andygrunwald]

This attribute does not exist in ChangeInfo yet. See

go-gerrit/changes.go

Line 427 in 0983e87

type ChangeInfo struct {

I am happy to accept a PR that integrates this attribute.

[Ai-feier]

This attribute does not exist in ChangeInfo yet. See

go-gerrit/changes.go

Line 427 in 0983e87

type ChangeInfo struct {

I am happy to accept a PR that integrates this attribute.

I'm working on the gerrit webhook development using go-gerrit, but go-gerrit has some missing fields, and currently I can implement my needs by combining ChangeInfo and EventInfo, but this method is not suitable for long-term and is not good for performance. I'd like to mention a few PRs to make go-gerrit more compatible.

[andygrunwald]

@Ai-feier Sure, go ahead.
Easy PRs that are in line with the documentation (e.g. adding new attributes) may be merged quickly.

More complicated PRs (as you mentioned some Performance topics), may benefit from an issue and a more detailed plan/design discussion before putting hours of work in.

[Ai-feier]

@Ai-feier Sure, go ahead. Easy PRs that are in line with the documentation (e.g. adding new attributes) may be merged quickly.

More complicated PRs (as you mentioned some Performance topics), may benefit from an issue and a more detailed plan/design discussion before putting hours of work in.

I also want to be faster, but I'm on a business trip and need to wait until the end of work to do it

[Ai-feier]

@Ai-feier Sure, go ahead. Easy PRs that are in line with the documentation (e.g. adding new attributes) may be merged quickly.
More complicated PRs (as you mentioned some Performance topics), may benefit from an issue and a more detailed plan/design discussion before putting hours of work in.

I also want to be faster, but I'm on a business trip and need to wait until the end of work to do it

I also want to be faster, but I'm on a business trip and need to wait until the end of work to do it

[Ai-feier]

please merge the pr: #168