From b3bafefe1966300b68d547c3f5c3c4e3e36bedd9 Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Fri, 27 Sep 2024 22:28:53 +0200 Subject: [PATCH] Fix search session filter functional test (#193812) ## Summary Fixes https://github.com/elastic/kibana/issues/192510. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Davis McPhee --- .../test_suites/data_plugin/session.ts | 33 ++++++++++++++----- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/test/plugin_functional/test_suites/data_plugin/session.ts b/test/plugin_functional/test_suites/data_plugin/session.ts index c44e606aa2d0422..773664da7510e0c 100644 --- a/test/plugin_functional/test_suites/data_plugin/session.ts +++ b/test/plugin_functional/test_suites/data_plugin/session.ts @@ -23,28 +23,33 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide const toasts = getService('toasts'); const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); + const retry = getService('retry'); + const browser = getService('browser'); const getSessionIds = async () => { const sessionsBtn = await testSubjects.find('showSessionsButton'); await sessionsBtn.click(); const toast = await toasts.getElementByIndex(1); const sessionIds = await toast.getVisibleText(); + await toasts.dismissAll(); return sessionIds.split(','); }; - // Failing: See https://github.com/elastic/kibana/issues/192510 - // Failing: See https://github.com/elastic/kibana/issues/192510 - describe.skip('Session management', function describeSessionManagementTests() { + const clearSessionIds = async () => { + await testSubjects.click('clearSessionsButton'); + await toasts.dismissAll(); + }; + + describe('Session management', function describeSessionManagementTests() { describe('Discover', () => { before(async () => { await common.navigateToApp('discover'); - await testSubjects.click('clearSessionsButton'); + await clearSessionIds(); await header.waitUntilLoadingHasFinished(); }); afterEach(async () => { - await testSubjects.click('clearSessionsButton'); - await toasts.dismissAll(); + await clearSessionIds(); }); it('Starts on index pattern select', async () => { @@ -93,8 +98,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide }); afterEach(async () => { - await testSubjects.click('clearSessionsButton'); - await toasts.dismissAll(); + await clearSessionIds(); }); after(async () => { @@ -115,6 +119,19 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide }); it('starts a session on filter change', async () => { + // For some reason, when loading the dashboard, sometimes the filter doesn't show up, so we + // refresh until it shows up + await retry.try( + async () => { + const hasFilter = await filterBar.hasFilter('animal', 'dog'); + if (!hasFilter) throw new Error('filter not found'); + }, + async () => { + await browser.refresh(); + await header.waitUntilLoadingHasFinished(); + await clearSessionIds(); + } + ); await filterBar.removeFilter('animal'); const sessionIds = await getSessionIds(); expect(sessionIds.length).to.be(1);