Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

wrapFunctionWithScopeApply breaks eventDataTransform #122

Open
adieu opened this issue Jul 1, 2014 · 3 comments · May be fixed by #123
Open

wrapFunctionWithScopeApply breaks eventDataTransform #122

adieu opened this issue Jul 1, 2014 · 3 comments · May be fixed by #123

Comments

@adieu
Copy link

adieu commented Jul 1, 2014

eventDataTransform is expected to return a transformed event object. But wrapFunctionWithScopeApply calls the wrapped function with $timeout which is async and the wrapper function just return nil.

To fix this issue, we have to keep a list of settings required to be sync and avoid wrap them with wrapFunctionWithScopeApply.
@joshkurz
Copy link
Contributor

joshkurz commented Jul 2, 2014

this is most likely related to #108.
If so please close.
If not, then please elaborate.

@adieu
Copy link
Author

adieu commented Jul 2, 2014

I think they're two different bugs related to the same function. I'll contribute a PR for this one.

@adieu adieu linked a pull request Jul 2, 2014 that will close this issue
Open
@hairlessOrphan
Copy link

eventRender suffers from this bug, too.

To repro, just add to the calendar config:

eventRender: function () { return false; }

and observe as nothing happens on the callback. As per fullcalendar's spec, when eventRender's callback returns false, the event is not rendered on the calendar.

@M0nter0 M0nter0 mentioned this issue Feb 16, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't wrap callback functions which need to return value to fullcalendar... adieu/ui-calendar
3 participants
@adieu @joshkurz @hairlessOrphan