Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux persists store version #119

Open
janrtvld opened this issue Oct 6, 2022 · 0 comments
Open

Redux persists store version #119

janrtvld opened this issue Oct 6, 2022 · 0 comments
Labels
improvement Improve current implementation

Comments

@janrtvld
Copy link
Contributor

janrtvld commented Oct 6, 2022

Currently, when we update the redux store with some new functionality we have to up the version. This is because if the store differs from the store that is being replenished from the localStorage there might be issues.

This is quite annoying and easy to forget. I think we can fix this with the following:

Currently we do a check in App.tsx to check if the server has been reset. This is because we wipe the server over the weekend to not clutter it up with billions of connections. What if we also save the current date in the store and then check before replenishing if this date is after the last server reset. If the server has been reset we don't replenish the store.

Does this make sense? It does feel a bit hacky so open to other suggestions.

@janrtvld janrtvld added enhancement New feature or request improvement Improve current implementation and removed enhancement New feature or request labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve current implementation
Projects
None yet
Development

No branches or pull requests

1 participant