feat: add documentation for direct access to Azure Storage accounts #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionicsolutions
requested changes
Nov 22, 2022
| To access files in an Azure Blob Storage container for running _Anovos_ in Azure Databricks platform, | ||
| you need to mount that container in the DBFS path. | ||
|
|
||
| ```spark.conf.set("fs.azure.account.key.<storage-account-name>.dfs.core.windows.net", <storage-account-key>``` |
Collaborator
There was a problem hiding this comment.
Where do I use/add this line?
ionicsolutions
requested changes
Nov 22, 2022
Collaborator
ionicsolutions
left a comment
ionicsolutions
left a comment
There was a problem hiding this comment.
Please also augment/update the intro of the page:
1. Processing datasets stored directly on DBFS
2. Processing datasets stored on [Azure Blob Storage](https://azure.microsoft.com/services/storage/blobs/)
Generally, we recommend the first option, as it requires slightly less configuration.
However, if you're already storing your datasets on Azure Blob Storage, mounting the respective containers
to DBFS allows you to directly process them with _Anovos_.
| To access files in an Azure Blob Storage container for running _Anovos_ in Azure Databricks platform, | ||
| you need to mount that container in the DBFS path. | ||
|
|
||
| ```spark.conf.set("fs.azure.account.key.<storage-account-name>.dfs.core.windows.net", <storage-account-key>``` |
|
|
||
| Here, | ||
| - `<storage-account-name>` is the name of your Azure Blob Storage account | ||
| - `<storage-account-key>` is the value of the Storage account key (TODO: this is bad practice and should be solved with a secret) |
Collaborator
There was a problem hiding this comment.
@mathiaspet Please provide information on how to do this properly. Don't mention a bad practice in the docs :)
Collaborator
There was a problem hiding this comment.
Also, I would assume that this is fine in certain situations and not others. Would be great to tell people when/why this is (not) recommended.
| Once you have updated the configuration file, copy it to Azure Databricks using the same command that was used | ||
| in [Step 1.2](#step-12-prepare-and-copy-the-workflow-configuration-and-data-to-dbfs). | ||
|
|
||
| You can now configure the `file_path` to point to that location. |
| The remaining steps are the same as above, so please continue with | ||
| [Step 1.4](#step-14-configure-and-launch-an-anovos-workflow-as-a-databricks-job) | ||
|
|
||
| ## 3. Anovos on Azure Databricks using direct access to Azure Blob Storage containers |
Collaborator
There was a problem hiding this comment.
Can we add some information why one would want to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.