Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage for utils/parser.js #197

Open
designfrontier opened this issue Jan 15, 2016 · 6 comments
Open

Expand test coverage for utils/parser.js #197

designfrontier opened this issue Jan 15, 2016 · 6 comments

Comments

@designfrontier
Copy link
Member

https://coveralls.io/builds/4658528 Looks like it is covered about 90%...

Locally you can get this number by running npm test. That creates an output to console and the more useful coverage directory. In the coverage directory (run it with a static server like http-server) you can drill into the coverage in the browser and see exactly what lines are not tested currently.

@barrotsteindev
Copy link

Hello,
I would like to give this a shot.

@designfrontier
Copy link
Member Author

@barrotsteindev awesome! Let me know if you have questions or need a hand with anything

@barrotsteindev
Copy link

Well I have looked into it and it seems like this issue is no longer relevant.
Could you please just make sure I'm not missing anything?
Thanks in advance.

@designfrontier
Copy link
Member Author

@barrotsteindev It looks like the coverage is still about 93% with a couple of error states that are untested. Specifically lines 60 and 84 are not executed in the test suite. If you wanted to write some tests to get them under coverage that would be great.

There might need to be some refactoring to make that a little easier to do... but I think it is possible as is with some correct setup of the params passed into the function

@barrotsteindev
Copy link

@designfrontier
I have started to work on this in a forked repo: https://github.com/barrotsteindev/monument/blob/utils_parser_tests
I haven't been able to test line 87 in the parser.js, and seem kind of stuck.
Would you have a tip or an idea how to get this line to be executed?
Thanks in advance.

@SatabrataPaul-GitAc
Copy link

SatabrataPaul-GitAc commented Sep 25, 2022

Hi @designfrontier
Myself Satabrata Paul. a passionate backend and cloud developer from India
I would like to get started in contributing to this project , for Hacktoberfest this year . i.e. 2022
I have previously contributed to major open source projects (presently working with The Linux Foundation - LFX Mentorship)
Can we schedule a 1:1 call over gmeet ?
I just wanted to understand the code and the repository a bit better which would in turn help me pickup the issues

I am located in India (IST)
Here is my email id for reference : paulsatabrata@gmail.com

Hoping for a response soon !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants