-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose the statsdclient to the request #529
Comments
Hi I've been looking for a project to get into open source, I think I could handle this. If I'm understanding correctly, you would simply like statsdClient added inside the connection object so it can be accessed in a monument project route file |
Yeah! As I am thinking about this more it might actually be best to just expose it at the same level as the events object. That way you could do |
I submitted a PR that allows access to statsd anywhere via but as I commented there, I couldn't figure out how to test it |
Line 96-108 of index.test.js are a pretty simple approach to testing this. Basically assert that the statsd client is returned on the app. The rest of the tests around statsd are already there so testing it in that location isn't needed. |
Will do! And thanks for the heads up on the test stuff, I should have poked around in there more |
Did this change make it? |
This would facilitate users doing custom statsd stuff and building out there own stats for performance metrics etc.
The statsd client already exists in the router.js file and in the correct scope to be added to the connection object passed to route events. Just needs to be added.
The text was updated successfully, but these errors were encountered: