Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag for version v2.5.9 missing #358

Open
sschmittsva opened this issue Dec 12, 2024 · 10 comments
Open

Tag for version v2.5.9 missing #358

sschmittsva opened this issue Dec 12, 2024 · 10 comments

Comments

@sschmittsva
Copy link
Contributor

The tag for version v2.5.9 missing. Can you please create it?

@lakrass
Copy link
Contributor

lakrass commented Dec 12, 2024

we should maybe add a notice to the changelog, that the vault_version_suffix variable has been introdruced before doing so. This change affects pretty much everyone who has used the vault_version variable.

@FalcoSuessgott
Copy link
Collaborator

released a new major version of v3.0.0. I can't find vault_version_suffix , you mean vault_version_repo_suffix? Are you certain its a new var?

@lakrass
Copy link
Contributor

lakrass commented Dec 12, 2024

My bad, it is vault_version_repo_suffix which was added by @sschmittsva in #353

@lakrass
Copy link
Contributor

lakrass commented Dec 12, 2024

I'm pretty sure it is new. In the past I had to define my vault_version as vault_version: 1.18.2-1 for the role to work with deb packages

@lakrass
Copy link
Contributor

lakrass commented Dec 12, 2024

I also checked the code of Commit 5ed64bc. No hint of vault_version_repo_suffix

@sschmittsva
Copy link
Contributor Author

First I've introduced:

vault_version_repo_suffix:

vault_version_repo_suffix: "{{ '+ent' if vault_enterprise }}-1"

but then I've changed my mind and put explicitely debian in the name:

vault_version_debian_repo_suffix:

vault_version_debian_repo_suffix: "-1"

@FalcoSuessgott
Copy link
Collaborator

FalcoSuessgott commented Dec 15, 2024

@bbaassssiiee, not sure whether you have sufficient permissions, but is it possible to allow Semantic Releaser to push to master/main branch without requiring a PR in order to automatically publish releases including changelogs? rel. https://github.com/ansible-community/ansible-vault/actions/runs/12334394683/job/34424540800#step:3:92.

If not, who could we reach out to instead?

@bbaassssiiee
Copy link
Member

I don't have the permissions. Dunno who has. This repo needs new maintainers.

@lakrass
Copy link
Contributor

lakrass commented Dec 17, 2024

@sschmittsva and me would be happy to help out with that :)

@bbaassssiiee
Copy link
Member

@ssbarnea please add them to org ansible-community and team hashicorp-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants