Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update banner for RTD #1878

Open
oraNod opened this issue Sep 12, 2024 · 0 comments
Open

Update banner for RTD #1878

oraNod opened this issue Sep 12, 2024 · 0 comments
Labels
DaWGs Good discussion item for the DaWGs needs_triage Needs a first human triage before being processed. RTD migration Related to the migration of content to readthedocs

Comments

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

On RTD the url path starts with /projects/ so the EOL banner is displayed on all branches, including devel.

To fix this, we need to update the template:

if (startsWith(current_url_path, "/ansible-core/")) {

You can reproduce this issue by visiting https://ansible.readthedocs.io/projects/ansible-core/devel/

The EOL banner displays instead of the current / devel banner.

EOL banner is this one:

image

Current / devel banner should be the same as https://docs.ansible.com/ansible-core/devel/index.html

@oraNod oraNod added the DaWGs Good discussion item for the DaWGs label Sep 12, 2024
@ansible-documentation-bot ansible-documentation-bot bot added the needs_triage Needs a first human triage before being processed. label Sep 12, 2024
@oraNod oraNod added the RTD migration Related to the migration of content to readthedocs label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DaWGs Good discussion item for the DaWGs needs_triage Needs a first human triage before being processed. RTD migration Related to the migration of content to readthedocs
Projects
Status: 🆕 Triage
Development

No branches or pull requests

1 participant