diff --git a/src/ansible_navigator/command_runner/command_runner.py b/src/ansible_navigator/command_runner/command_runner.py index e0a70bc63..8daed6d24 100644 --- a/src/ansible_navigator/command_runner/command_runner.py +++ b/src/ansible_navigator/command_runner/command_runner.py @@ -68,7 +68,7 @@ def run_command(command: Command) -> None: capture_output=True, check=True, text=True, - shell=True, # noqa:S602 + shell=True, ) command.return_code = proc_out.returncode command.stdout = proc_out.stdout diff --git a/src/ansible_navigator/configuration_subsystem/navigator_post_processor.py b/src/ansible_navigator/configuration_subsystem/navigator_post_processor.py index 10d0e7e3c..e2fea81a6b 100644 --- a/src/ansible_navigator/configuration_subsystem/navigator_post_processor.py +++ b/src/ansible_navigator/configuration_subsystem/navigator_post_processor.py @@ -676,7 +676,7 @@ def lintables( try: subprocess.run( "ansible-lint --version", # noqa:S607 - shell=True, # noqa:S602 + shell=True, check=True, ) except subprocess.CalledProcessError: diff --git a/src/ansible_navigator/data/catalog_collections.py b/src/ansible_navigator/data/catalog_collections.py index c15d87a0f..a8bbe4636 100644 --- a/src/ansible_navigator/data/catalog_collections.py +++ b/src/ansible_navigator/data/catalog_collections.py @@ -586,7 +586,7 @@ def run_command(cmd: list[str]) -> dict[str, str]: capture_output=True, check=True, text=True, - shell=True, # noqa:S602 + shell=True, ) except subprocess.CalledProcessError as exc: return {"error": str(exc)} diff --git a/src/ansible_navigator/data/image_introspect.py b/src/ansible_navigator/data/image_introspect.py index 692cee056..444b7cb59 100644 --- a/src/ansible_navigator/data/image_introspect.py +++ b/src/ansible_navigator/data/image_introspect.py @@ -46,7 +46,7 @@ def run_command(command: Command) -> None: capture_output=True, check=True, text=True, - shell=True, # noqa:S602 + shell=True, ) command.stdout = proc_out.stdout except subprocess.CalledProcessError as exc: diff --git a/src/ansible_navigator/image_manager/puller.py b/src/ansible_navigator/image_manager/puller.py index 17b508168..4fe5d3d76 100644 --- a/src/ansible_navigator/image_manager/puller.py +++ b/src/ansible_navigator/image_manager/puller.py @@ -103,7 +103,7 @@ def _check_for_image(self) -> None: cmd_parts = [self._container_engine, "image", "inspect", self._image] self._log_message(level=logging.DEBUG, message=f"Command: {shlex_join(cmd_parts)}") subprocess.run( - cmd_parts, # noqa:S603 + cmd_parts, check=True, capture_output=True, ) @@ -219,7 +219,7 @@ def pull_stdout(self) -> None: cmd_to_run, check=True, stderr=stderr_pipe, - shell=True, # noqa:S602 + shell=True, env=os.environ, ) self._log_message(level=logging.INFO, message="Execution environment updated")