optional param

Author: zkayyali812

src/aap_eda/api/serializers/decision_environment.py

@@ -73,7 +73,7 @@ def validate(self, data):
         if eda_credential_id:
             validators.check_if_de_valid(image_url, eda_credential_id)
         else:
-            validators.check_if_de_valid(image_url, -1)
+            validators.check_if_de_valid(image_url)
 
         return data
 

src/aap_eda/core/validators.py

@@ -62,7 +62,7 @@ def check_if_de_exists(decision_environment_id: int) -> int:
     return decision_environment_id
 
 
-def check_if_de_valid(image_url: str, eda_credential_id: int):
+def check_if_de_valid(image_url: str, eda_credential_id: int = None):
     # The OCI standard format for the image url is a combination of a host
     # (with optional port) separated from the image path (with optional tag) by
     # a slash: <host>[:port]/<path>[:tag].
@@ -138,7 +138,7 @@ def check_if_de_valid(image_url: str, eda_credential_id: int):
             % {"image_url": image_url, "tag": tag}
         )
 
-    if eda_credential_id != -1:
+    if eda_credential_id:
         credential = get_credential_if_exists(eda_credential_id)
         inputs = yaml.safe_load(credential.inputs.get_secret_value())
         credential_host = inputs.get("host")