Skip to content

Commit c1be5b6

Browse files
committed
[AAP-9727] Remove /tasks endpoint
1 parent 1006529 commit c1be5b6

File tree

14 files changed

+34
-346
lines changed

14 files changed

+34
-346
lines changed

src/aap_eda/api/serializers/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
RulesetOutSerializer,
6262
RulesetSerializer,
6363
)
64-
from .tasks import TaskRefSerializer, TaskSerializer
6564
from .user import (
6665
AwxTokenCreateSerializer,
6766
AwxTokenSerializer,
@@ -94,9 +93,6 @@
9493
"RulesetSerializer",
9594
"RuleOutSerializer",
9695
"RuleSerializer",
97-
# tasks
98-
"TaskRefSerializer",
99-
"TaskSerializer",
10096
# activations
10197
"ActivationSerializer",
10298
"ActivationListSerializer",

src/aap_eda/api/serializers/project.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class Meta:
3030
"git_hash",
3131
"import_state",
3232
"import_error",
33-
"import_task_id",
3433
"created_at",
3534
"modified_at",
3635
]
@@ -98,7 +97,6 @@ class Meta:
9897
"git_hash",
9998
"import_state",
10099
"import_error",
101-
"import_task_id",
102100
"created_at",
103101
"modified_at",
104102
]
@@ -126,7 +124,6 @@ def to_representation(self, project):
126124
"credential": credential,
127125
"import_state": project["import_state"],
128126
"import_error": project["import_error"],
129-
"import_task_id": project["import_task_id"],
130127
"created_at": project["created_at"],
131128
"modified_at": project["modified_at"],
132129
}

src/aap_eda/api/serializers/tasks.py

Lines changed: 0 additions & 46 deletions
This file was deleted.

src/aap_eda/api/urls.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
router.register("rulesets", views.RulesetViewSet)
3232
router.register("rules", views.RuleViewSet)
3333
router.register("roles", views.RoleViewSet)
34-
router.register("tasks", views.TaskViewSet, basename="task")
3534
router.register("activations", views.ActivationViewSet)
3635
router.register("activation-instances", views.ActivationInstanceViewSet)
3736
router.register("audit-rules", views.AuditRuleViewSet)

src/aap_eda/api/views/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
RulesetViewSet,
2424
RuleViewSet,
2525
)
26-
from .tasks import TaskViewSet
2726
from .user import CurrentUserAwxTokenViewSet, CurrentUserView, UserViewSet
2827

2928
__all__ = (
@@ -38,8 +37,6 @@
3837
"RulebookViewSet",
3938
"RulesetViewSet",
4039
"RuleViewSet",
41-
# tasks
42-
"TaskViewSet",
4340
# activations
4441
"ActivationViewSet",
4542
"ActivationInstanceViewSet",

src/aap_eda/api/views/tasks.py

Lines changed: 0 additions & 68 deletions
This file was deleted.

src/aap_eda/core/enums.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,8 @@ class ResourceType(DjangoStrEnum):
4242
ACTIVATION_INSTANCE = "activation_instance"
4343
AUDIT_RULE = "audit_rule"
4444
AUDIT_EVENT = "audit_event"
45-
TASK = "task"
4645
USER = "user"
4746
PROJECT = "project"
48-
INVENTORY = "inventory"
4947
EXTRA_VAR = "extra_var"
5048
RULEBOOK = "rulebook"
5149
ROLE = "role"
@@ -63,13 +61,6 @@ class Action(DjangoStrEnum):
6361
RESTART = "restart"
6462

6563

66-
class InventorySource(DjangoStrEnum):
67-
PROJECT = "project"
68-
COLLECTION = "collection"
69-
USER_DEFINED = "user_defined"
70-
EXECUTION_ENV = "execution_env"
71-
72-
7364
# TODO: rename to "RulebookProcessStatus" or "ParentProcessStatus"
7465
class ActivationStatus(DjangoStrEnum):
7566
STARTING = "starting"

src/aap_eda/core/management/commands/create_initial_data.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@
3636
"activation_instance": ["read", "delete"],
3737
"audit_rule": ["read"],
3838
"audit_event": ["read"],
39-
"task": ["read"],
4039
"user": ["create", "read", "update", "delete"],
4140
"project": ["create", "read", "update", "delete"],
42-
"inventory": ["create", "read", "update", "delete"],
4341
"extra_var": ["create", "read", "update", "delete"],
4442
"rulebook": ["create", "read", "update", "delete"],
4543
"role": ["create", "read", "update", "delete"],
@@ -56,9 +54,7 @@
5654
"activation_instance": ["read"],
5755
"audit_rule": ["read"],
5856
"audit_event": ["read"],
59-
"task": ["read"],
6057
"project": ["create", "read", "update", "delete"],
61-
"inventory": ["create", "read", "update", "delete"],
6258
"extra_var": ["create", "read", "update", "delete"],
6359
"rulebook": ["create", "read", "update", "delete"],
6460
"decision_environment": ["create", "read", "update", "delete"],
@@ -86,9 +82,7 @@
8682
"activation_instance": ["read", "delete"],
8783
"audit_rule": ["read"],
8884
"audit_event": ["read"],
89-
"task": ["read"],
9085
"project": ["create", "read", "update", "delete"],
91-
"inventory": ["create", "read", "update", "delete"],
9286
"extra_var": ["create", "read", "update", "delete"],
9387
"rulebook": ["create", "read", "update", "delete"],
9488
"decision_environment": ["create", "read", "update", "delete"],
@@ -107,9 +101,7 @@
107101
"activation_instance": ["read"],
108102
"audit_rule": ["read"],
109103
"audit_event": ["read"],
110-
"task": ["read"],
111104
"project": ["read"],
112-
"inventory": ["read"],
113105
"extra_var": ["read"],
114106
"rulebook": ["read"],
115107
"decision_environment": ["read"],
@@ -125,10 +117,8 @@
125117
"activation_instance": ["read"],
126118
"audit_rule": ["read"],
127119
"audit_event": ["read"],
128-
"task": ["read"],
129120
"user": ["read"],
130121
"project": ["read"],
131-
"inventory": ["read"],
132122
"extra_var": ["read"],
133123
"rulebook": ["read"],
134124
"role": ["read"],
@@ -145,9 +135,7 @@
145135
"activation_instance": ["read"],
146136
"audit_rule": ["read"],
147137
"audit_event": ["read"],
148-
"task": ["read"],
149138
"project": ["read"],
150-
"inventory": ["read"],
151139
"extra_var": ["read"],
152140
"rulebook": ["read"],
153141
"decision_environment": ["read"],
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# Generated by Django 4.2.7 on 2024-02-09 14:43
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
dependencies = [
8+
("core", "0022_activationrequestqueue_process_parent_id_and_more"),
9+
]
10+
11+
operations = [
12+
migrations.AlterField(
13+
model_name="permission",
14+
name="resource_type",
15+
field=models.TextField(
16+
choices=[
17+
("activation", "activation"),
18+
("activation_instance", "activation_instance"),
19+
("audit_rule", "audit_rule"),
20+
("audit_event", "audit_event"),
21+
("user", "user"),
22+
("project", "project"),
23+
("extra_var", "extra_var"),
24+
("rulebook", "rulebook"),
25+
("role", "role"),
26+
("decision_environment", "decision_environment"),
27+
("credential", "credential"),
28+
]
29+
),
30+
),
31+
migrations.DeleteModel(
32+
name="Inventory",
33+
),
34+
]

src/aap_eda/core/models/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from .credential import Credential
1818
from .decision_environment import DecisionEnvironment
1919
from .event_stream import EventStream
20-
from .inventory import Inventory
2120
from .job import (
2221
ActivationInstanceJobInstance,
2322
Job,
@@ -47,7 +46,6 @@
4746
"AuditEvent",
4847
"AuditRule",
4948
"ExtraVar",
50-
"Inventory",
5149
"JobInstanceEvent",
5250
"JobInstanceHost",
5351
"JobInstance",

src/aap_eda/core/models/inventory.py

Lines changed: 0 additions & 49 deletions
This file was deleted.

tests/integration/api/test_project.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ def test_retrieve_project_failed_state(client: APIClient):
143143
data = response.json()
144144

145145
assert data["import_state"] == "failed"
146-
assert data["import_task_id"] == "3677eb4a-de4a-421a-a73b-411aa502484d"
147146
assert data["import_error"] == "Unexpected error. Please contact support."
148147

149148
assert_project_data_details(data, project)
@@ -496,18 +495,13 @@ def assert_project_data_details(data: Dict[str, Any], project: models.Project):
496495

497496

498497
def model_to_data_common(project: models.Project):
499-
import_task_id = project.import_task_id
500-
if import_task_id is not None:
501-
import_task_id = str(import_task_id)
502-
503498
return {
504499
"id": project.id,
505500
"url": project.url,
506501
"name": project.name,
507502
"description": project.description,
508503
"git_hash": project.git_hash,
509504
"import_state": project.import_state,
510-
"import_task_id": import_task_id,
511505
"import_error": project.import_error,
512506
"created_at": project.created_at.strftime(DATETIME_FORMAT),
513507
"modified_at": project.modified_at.strftime(DATETIME_FORMAT),

0 commit comments

Comments
 (0)