handle zero value as per suggestion

Signed-off-by: Alex <aizquier@redhat.com>

Author: Alex-Izquierdo

src/aap_eda/services/activation/engine/podman.py

@@ -48,9 +48,7 @@ def _get_podman_socket_url() -> str:
 
 def get_podman_client() -> PodmanClient:
     """Podman client factory."""
-    params = {}
-    if settings.PODMAN_SOCKET_TIMEOUT:
-        params["timeout"] = settings.PODMAN_SOCKET_TIMEOUT
+    params = {"timeout": settings.PODMAN_SOCKET_TIMEOUT}
     podman_url = _get_podman_socket_url()
     params["base_url"] = podman_url
     LOGGER.info(f"Using podman socket: {podman_url}")

src/aap_eda/settings/default.py

@@ -362,7 +362,10 @@ def _config_authentication_backends():
         "ws://", "http://"
     ).replace("wss://", "https://")
 PODMAN_SOCKET_URL = settings.get("PODMAN_SOCKET_URL", None)
-PODMAN_SOCKET_TIMEOUT = settings.get("PODMAN_SOCKET_TIMEOUT", None)
+PODMAN_SOCKET_TIMEOUT = settings.get("PODMAN_SOCKET_TIMEOUT", default=0)
+# zero raises an exception, None takes the socket default
+if PODMAN_SOCKET_TIMEOUT == 0:
+    PODMAN_SOCKET_TIMEOUT = None
 PODMAN_MEM_LIMIT = settings.get("PODMAN_MEM_LIMIT", "200m")
 PODMAN_ENV_VARS = settings.get("PODMAN_ENV_VARS", {})
 PODMAN_MOUNTS = settings.get("PODMAN_MOUNTS", [])

tests/integration/services/activation/engine/test_podman.py

@@ -46,6 +46,7 @@
 )
 
 from .utils import InitData, get_ansible_rulebook_cmdline, get_request
+from aap_eda.settings.default import settings as orig_dynaconf_settings
 
 DATA_DIR = Path(__file__).parent / "data"
 
@@ -150,6 +151,20 @@ def test_get_podman_client_with_timeout(settings):
     assert client.api.timeout == 10
 
 
+def test_get_podman_client_with_zero_timeout():
+    """Test setting the timeout for the Podman client to zero."""
+    with mock.patch("aap_eda.settings.default.settings.get") as get_mock:
+
+        def get_side_effect(*args, **kwargs):
+            if args[0] == "PODMAN_SOCKET_TIMEOUT":
+                return 0
+            return orig_dynaconf_settings.get(*args, **kwargs)
+
+        get_mock.side_effect = get_side_effect
+        client = get_podman_client()
+        assert client.api.timeout is None
+
+
 def test_get_podman_client(settings):
     settings.PODMAN_SOCKET_URL = None
     uid_0_mock = mock.Mock(return_value=0)