Create per namespace inbound repos on all namespace creation (#816) (#899)

This will create a new Repository and Distribution for every
Namespace in Galaxy.

Add delete() to Namespace model.
Remove delete() from NamespaceManager.
Previous unit test for delete was using a query_set.delete()
which does a bulk delete, and not using the NamespaceManager.delete()

Update unit tests.

Issue: AAH-739
(cherry picked from commit eaea077)

Co-authored-by: Adrian Likins <alikins@redhat.com>

Author: patchback[bot]

CHANGES/739.bugfix

@@ -0,0 +1 @@
+Create 'inbound-namespaces' whenever a namespace is created.

galaxy_ng/app/models/namespace.py

@@ -9,7 +9,6 @@
 from galaxy_ng.app.access_control import mixins
 from galaxy_ng.app.constants import INBOUND_REPO_NAME_FORMAT
 
-
 __all__ = ("Namespace", "NamespaceLink")
 
 
@@ -48,9 +47,11 @@ def bulk_create(self, objs, **kwargs):
             create_inbound_repo(obj.name)
         return super().bulk_create(objs, **kwargs)
 
-    def delete(self):
-        delete_inbound_repo(self.name)
-        return super().delete()
+    def get_or_create(self, *args, **kwargs):
+        ns, created = super().get_or_create(*args, **kwargs)
+        if created:
+            create_inbound_repo(kwargs['name'])
+        return ns, created
 
 
 class Namespace(LifecycleModel, mixins.GroupModelPermissionsMixin, AutoDeleteObjPermsMixin):
@@ -96,6 +97,10 @@ def set_links(self, links):
             for link in links
         )
 
+    def delete(self, *args, **kwargs):
+        delete_inbound_repo(self.name)
+        return super().delete(*args, **kwargs)
+
     class Meta:
         permissions = (
             ('upload_to_namespace', 'Can upload collections to namespace'),

galaxy_ng/tests/unit/test_models.py

@@ -45,9 +45,12 @@ def test_new_namespace_creates_inbound_repo(self):
     def test_delete_namespace_deletes_inbound_repo(self):
         """When deleting a Namespace the manager should delete inbound instances."""
         Namespace.objects.get_or_create(name=self.namespace_name)
-        Namespace.objects.filter(name=self.namespace_name).delete()
+        ns = Namespace.objects.get(name=self.namespace_name)
+        ns.delete()
 
         inbound_name = INBOUND_REPO_NAME_FORMAT.format(namespace_name=self.namespace_name)
+
         self.assertFalse(Namespace.objects.filter(name=self.namespace_name).exists())
+
         self.assertFalse(AnsibleRepository.objects.filter(name=inbound_name).exists())
         self.assertFalse(AnsibleDistribution.objects.filter(name=inbound_name).exists())