single_get/post vs Session

[ohartl]

Is there a reason for both of those to exist? Is it legacy code? @ansibleguy

I am working on a pull request, where I need to do some work in the api client. I wonder if we could just replace the both single_get and single_post by its Session::get and Session::post alternative?

[ansibleguy]

Greetings!

I actually use them in some modules that have a simple logic and only need to perform one call, so we do not have to deal with opening and closing the session.

You are right that it can basically be replaced by the session-based one.

I refactored the single_get and single_post to act as wrapper for the session-based handling: 353cef6

This removes the duplicate logic.

[ohartl]

Thanks, this already simplifies things :)

[ohartl]

Did create my PR now #46

[ansibleguy]

Note: We could also implement a context manager for the session-class so it auto-closes.
Might be even cleaner.

[ohartl]

This sounds really good. To be fair, I am not an python expert.
This would definitely make api calls more "fire and forget".

[ansibleguy]

Is now also implemented: https://opnsense.ansibleguy.net/en/latest/usage/4_develop.html#api

[ohartl]

Btw. I also found Base::_api_get to be unused:

collection_opnsense/plugins/module_utils/base/base.py

Line 628 in 30512ce

def _api_get(self, cnf: dict) -> (dict, list):

[ansibleguy]

Thanks. I updated all references so they are consistent.