TEST: Refactor tests in test_07_Object3D.py to make them independent
#6956
+724
−741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a refactoring of the tests in
tests/system/general/test_07_Object3D.pywith the primary objective to make them independent of each other: The relative independence of the reworked tests has been successfully tested locally.These changes are meant to make testing more efficient (independence enables parallel execution), reliable and to ease future debugging.
Furthermore, a comprehensive review of the tests in particular for relevance and with the aim to improve code style and formatting has been performed.
The implemented changes are listed below :
aedtappfixture has been improved,create_copper_box,create_copper_sphereandcreate_copper_cylinderare being used everywhere possible throughout the tests,test_00_object_performanceis removed: No actual performance criteria was defined (time above which the test should fail) & we are using thecreate_boxmethod literally everywhere in these tests, so I guess that if performance was too bad, the timeout for the tests would be hit..test_01_bounding_boxandtest_01_bounding_dimensionwere merged,test_08_set_modelwas removed (was very short and had noassertstatement),test_08A_top_face&test_08B_bottom_facewere merged,test_08C_top_edge&test_08D_bottom_edgewere merged,test_print_objectwas updated to check slightly differently that the conversions tointwas successful,test_13_delete_selfwas merged into the newtest_delete_object,assertstatement was added to thetest_17_section_object,test_24_filter_faces_by_area&test_25_edges_by_lengthit was made sure that every part of the test is actually executed,test_26_unclassified_object&test_26a_delete_unclassified_objectwere merged,test_27b_object_suppress,test_27c_object_jsonalizeandtest_28_set_object_history_properties, some steps (similar to what is done intest_27_get_object_history_properties) are added and performed on the test objects to provide some relevant history for testing,test_28_set_object_history_properties, it was made sure that every part of the test is actually executed.Close #6943.