-
Notifications
You must be signed in to change notification settings - Fork 0
Overall doc edit for public release #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@PipKat Overall, this looks great! Thank you for all of your edits! To answer some of your observations in the PR description:
Federico and Oliver will be able to answer the more specific questions about the PyHPS content itself |
Incorporate review feedback from Kerry Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
|
@PipKat https://ansysproducthelpqa.win.ansys.com/account/secured?returnurl=/Views/Secured/prod_page.html?pn=Ansys%20HPC%20Platform%20Services&lang=en |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PipKat many thanks for the great work! I've tried to address your questions, let me know if you need more clarifications.
Regarding the items you raised in the PR description, I've created this issue to track it. I think would be best to address them in separate PRs - I'm a little worried of the merge conflicts between this and Kerry's branch.
@FedericoNegri This link is to the doc QA site. I can only link to the beta guide on the doc production site, which I've done. |
Documentation edits are to prepare for public release of the library. I deleted subsequent sections of the PR template because they did't apply. I've reorganized content so that it resides in the five standard sections for PyAnsys library documentation: Getting started, User guide, Examples, API reference, and Contribute.
General observations
includes
. For example, I changed "setup" to "set up" when it was used as a verb. However, I hope it was OK to edit the files that appear viaincludes
because they are also included in the ZIP file for the example (and I don't know how/when this ZIP file is generated).auth.rst
file, there is a TODO REVIEW paragraph that must definitely be removed! Also, lots of objects are missing descriptions. Would we be able to improve this section before releasing publicly?