From 93e30bc0d4d2ec904062285e33fb82322f3a92db Mon Sep 17 00:00:00 2001
From: younggglcy <younggglcy@gmail.com>
Date: Sat, 1 Feb 2025 00:13:09 +0800
Subject: [PATCH] fix: apply reviews

---
 src/io/pnpmWorkspaces.ts |  6 +++++-
 test/pnpmCatalog.test.ts | 36 ++++++++++++++++++++++++------------
 2 files changed, 29 insertions(+), 13 deletions(-)

diff --git a/src/io/pnpmWorkspaces.ts b/src/io/pnpmWorkspaces.ts
index 815be08..0a1ea0f 100644
--- a/src/io/pnpmWorkspaces.ts
+++ b/src/io/pnpmWorkspaces.ts
@@ -87,7 +87,7 @@ export async function writePnpmWorkspace(
   }
 
   if (changed)
-    await fs.writeFile(pkg.filepath, stringify(contents), 'utf-8')
+    await writeYaml(pkg, contents)
 
   // currently only support preserve yaml anchor and alias with single string value
   function updateCatalog(catalog: YAMLMap<Scalar.Parsed, Scalar.Parsed>, contents: Record<string, any>) {
@@ -117,3 +117,7 @@ export async function writePnpmWorkspace(
     }
   }
 }
+
+export function writeYaml(pkg: PnpmWorkspaceMeta, yamlContents: any) {
+  return fs.writeFile(pkg.filepath, stringify(yamlContents), 'utf-8')
+}
diff --git a/test/pnpmCatalog.test.ts b/test/pnpmCatalog.test.ts
index 117dacc..1147fee 100644
--- a/test/pnpmCatalog.test.ts
+++ b/test/pnpmCatalog.test.ts
@@ -1,10 +1,9 @@
 import type { CheckOptions, PnpmWorkspaceMeta } from '../src'
-import fs from 'node:fs/promises'
 import process from 'node:process'
-import { expect, it } from 'vitest'
-import { parse, parseDocument } from 'yaml'
+import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest'
+import { parse, parseDocument, stringify } from 'yaml'
 import { CheckPackages } from '../src'
-import { writePnpmWorkspace } from '../src/io/pnpmWorkspaces'
+import * as pnpmWorkspaces from '../src/io/pnpmWorkspaces'
 
 it('pnpm catalog', async () => {
   const options: CheckOptions = {
@@ -104,7 +103,25 @@ it('pnpm catalog', async () => {
   `)
 })
 
-it('pnpm catalog updates should preserve yaml anchors and aliases with single string value', async () => {
+describe('pnpm catalog updates', async () => {
+  // stringified yaml output that should be
+  // written to the pnpm-workspace.yaml file
+  let output: string | undefined
+  beforeAll(() => {
+    // mock fn writeYaml
+    vi.spyOn(pnpmWorkspaces, 'writeYaml').mockImplementation((_pkg: PnpmWorkspaceMeta, contents: any) => {
+      return Promise.resolve().then(() => {
+        output = stringify(contents)
+      })
+    })
+  })
+
+  afterAll(() => {
+    // @ts-expect-error we mocked it in `beforeAll` hook
+    pnpmWorkspaces.writeYaml.mockRestore()
+  })
+
+  it('pnpm catalog updates should preserve yaml anchors and aliases with single string value, when anchor is defined inline', async () => {
   const workspaceYamlContents = `
 catalog:
   react: &foo ^18.2.0
@@ -124,16 +141,11 @@ catalog:
     filepath: '',
     type: 'pnpm-workspace.yaml',
   }
-
-  let output: string
-  // @ts-expect-error testing purpose
-  fs.writeFile = (_path, data, _ops) => output = data
-
-  await writePnpmWorkspace(pkg, {})
-  // @ts-expect-error testing purpose
+    await pnpmWorkspaces.writePnpmWorkspace(pkg, {})
   expect(output).toMatchInlineSnapshot(`
 "catalog:
   react: &foo ^18.3.1
   react-dom: *foo
 "`)
+  })
 })