From c2b285734cbf15f9b628350e3bd3d6f65154fdef Mon Sep 17 00:00:00 2001 From: Simon He <57086651+Simon-He95@users.noreply.github.com> Date: Tue, 13 Aug 2024 14:30:22 +0800 Subject: [PATCH 1/5] fix(vscode): with lock version --- src/addons/vscode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/addons/vscode.ts b/src/addons/vscode.ts index e5fc951..fadff25 100644 --- a/src/addons/vscode.ts +++ b/src/addons/vscode.ts @@ -16,7 +16,7 @@ export const addonVSCode: Addon = { if (version && pkg.raw.engines?.vscode !== version) { // eslint-disable-next-line no-console console.log(`[addon] Updated VS Code engine field to ${version}`) - pkg.raw.engines.vscode = version + pkg.raw.engines.vscode = version.startsWith('^') ? version : '^' + version } }, } From d907b3566b9e1362220906823e101d2f93843336 Mon Sep 17 00:00:00 2001 From: Simon He <57086651+Simon-He95@users.noreply.github.com> Date: Tue, 13 Aug 2024 14:35:29 +0800 Subject: [PATCH 2/5] chore: update --- src/addons/vscode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/addons/vscode.ts b/src/addons/vscode.ts index fadff25..2aa4fd0 100644 --- a/src/addons/vscode.ts +++ b/src/addons/vscode.ts @@ -16,7 +16,7 @@ export const addonVSCode: Addon = { if (version && pkg.raw.engines?.vscode !== version) { // eslint-disable-next-line no-console console.log(`[addon] Updated VS Code engine field to ${version}`) - pkg.raw.engines.vscode = version.startsWith('^') ? version : '^' + version + pkg.raw.engines.vscode = version.startsWith('^') ? version : `^${version}` } }, } From c7d376f73b4f47c2bbd5d8ce3af9ed7fd8bef175 Mon Sep 17 00:00:00 2001 From: Simon He <57086651+Simon-He95@users.noreply.github.com> Date: Tue, 13 Aug 2024 14:44:17 +0800 Subject: [PATCH 3/5] chore: Update src/addons/vscode.ts Co-authored-by: Anthony Fu --- src/addons/vscode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/addons/vscode.ts b/src/addons/vscode.ts index 2aa4fd0..5d7d192 100644 --- a/src/addons/vscode.ts +++ b/src/addons/vscode.ts @@ -16,7 +16,7 @@ export const addonVSCode: Addon = { if (version && pkg.raw.engines?.vscode !== version) { // eslint-disable-next-line no-console console.log(`[addon] Updated VS Code engine field to ${version}`) - pkg.raw.engines.vscode = version.startsWith('^') ? version : `^${version}` + pkg.raw.engines.vscode = version.match(/[^><]/) ? version : `^${version}` } }, } From 64163a367d44cddefd00cd60450d218897fdc135 Mon Sep 17 00:00:00 2001 From: Simon He <57086651+Simon-He95@users.noreply.github.com> Date: Tue, 13 Aug 2024 14:47:37 +0800 Subject: [PATCH 4/5] chore: update --- src/addons/vscode.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/addons/vscode.ts b/src/addons/vscode.ts index 5d7d192..3896a0f 100644 --- a/src/addons/vscode.ts +++ b/src/addons/vscode.ts @@ -16,7 +16,7 @@ export const addonVSCode: Addon = { if (version && pkg.raw.engines?.vscode !== version) { // eslint-disable-next-line no-console console.log(`[addon] Updated VS Code engine field to ${version}`) - pkg.raw.engines.vscode = version.match(/[^><]/) ? version : `^${version}` + pkg.raw.engines.vscode = /^[^><]/.test(version) ? version : `^${version}` } }, } From 82e8078a983cb191c199075d1931597b76df1c3f Mon Sep 17 00:00:00 2001 From: Anthony Fu Date: Wed, 14 Aug 2024 18:13:07 +0200 Subject: [PATCH 5/5] chore: fix --- src/addons/vscode.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/addons/vscode.ts b/src/addons/vscode.ts index 3896a0f..0189c8c 100644 --- a/src/addons/vscode.ts +++ b/src/addons/vscode.ts @@ -16,7 +16,8 @@ export const addonVSCode: Addon = { if (version && pkg.raw.engines?.vscode !== version) { // eslint-disable-next-line no-console console.log(`[addon] Updated VS Code engine field to ${version}`) - pkg.raw.engines.vscode = /^[^><]/.test(version) ? version : `^${version}` + // If the version is not a range (fixed version), we prepend it with a caret + pkg.raw.engines.vscode = /[>^<:~]/.test(version) ? version : `^${version}` } }, }