Skip to content

missing quotes #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mio-19 opened this issue Apr 1, 2025 · 3 comments · Fixed by #626
Closed

missing quotes #602

mio-19 opened this issue Apr 1, 2025 · 3 comments · Fixed by #626
Labels
bug Something isn't working

Comments

@mio-19
Copy link

mio-19 commented Apr 1, 2025 •
edited
Loading

Image

I am expecting /bin/zsh -c "<command>" or <command> only without `zsh -c` when command contains space

However current version of forge is displaying in this incorrect format /bin/zsh -c <command> which doesn't represent what is truly being executed
@amitksingh1490 amitksingh1490 added the bug Something isn't working label Apr 1, 2025
@tusharmath
Copy link
Collaborator

How about this format:

11:11:11.111 zsh find . -name "SimpleBlockTerminationTest.scala"

@mio-19
Copy link
Author

mio-19 commented Apr 2, 2025

How about this format:

11:11:11.111 zsh find . -name "SimpleBlockTerminationTest.scala"

It looks better than the current format

@tusharmath
Copy link
Collaborator

I thought about this a little more @mio-19.
The current version is technically more accurate. It truly represents how the command has been executed and the used shell.

@tusharmath tusharmath mentioned this issue Apr 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: simplify command output formatting in shell execution antinomyhq/forge
3 participants
@tusharmath @amitksingh1490 @mio-19