fix: refactor to pass linter

Author: antoooks

cmd/gorepomod/internal/git/runner.go

@@ -174,7 +174,10 @@ func (gr *Runner) LoadRemoteTags(
 	_, err = gr.run(noHarmDone, "fetch", "-t", string(remoteUpstream), "master")
 	if err != nil {
 		// Handle if repo is not a fork
-		gr.run(noHarmDone, "fetch", "-t", "master")
+		_, err = gr.run(noHarmDone, "fetch", "-t", "master")
+		if err != nil {
+			_ = fmt.Errorf("failed to fetch tags from master")
+		}
 	}
 
 	gr.comment("loading remote tags")
@@ -364,16 +367,16 @@ func (gr *Runner) GetLatestTag(releaseBranch string) (string, error) {
 	// Assuming release branch has this format: release-path/to/module-vX.Y.Z
 	// and each release branch maintains tags, extract version from latest `releaseBranch`
 	gr.comment("extract version from latest release branch")
-	filteredBranchList, err := gr.run(noHarmDone, "branch", "-a", "--list", "*"+string(releaseBranch)+"*", "--sort=-committerdate")
+	filteredBranchList, err := gr.run(noHarmDone, "branch", "-a", "--list", "*"+releaseBranch+"*", "--sort=-committerdate")
 	if len(filteredBranchList) < 1 {
-		fmt.Errorf("latest tag not found for %s", releaseBranch)
+		_ = fmt.Errorf("latest tag not found for %s", releaseBranch)
 		return "", err
 	}
 	newestBranch := strings.Split(strings.ReplaceAll(filteredBranchList, "\r\n", "\n"), "\n")
 	split := strings.Split(newestBranch[0], "-")
 	latestTag = split[len(split)-1]
 	if err != nil {
-		fmt.Errorf("error getting latest tag for %s: %q", releaseBranch, err.Error())
+		_ = fmt.Errorf("error getting latest tag for %s", releaseBranch)
 	}
 
 	return latestTag, nil

cmd/gorepomod/internal/utils/utils.go

@@ -51,35 +51,34 @@ func SliceContains(slice []string, target string) bool {
 // Receive git remote url as input and produce string containing git repository name
 // e.g. kustomize, myrepo/kustomize
 func ParseGitRepositoryPath(urlString string) string {
-	var d []string = getUrlStringArray(urlString)
+	var d []string = getURLStringArray(urlString)
 	protocol := d[0]
 
 	var repoPath string
 
 	// for ssh protocol git@github.com:path/repo.git
-	if protocol == "git" {
+	switch protocol {
+	case "git":
 		repoPath = strings.Join(d[2:len(d)-1], "/") + "/" + d[3][:len(d[3])-4]
 		// https protocol https://github.com/path/repo.git
-	} else if protocol == "https" {
+	case "https":
 		repoPath = strings.Join(d[2:], "/")
 		repoPath = repoPath[:len(repoPath)-4]
 		// unsupported format
 		// TODO: confirm if we should handle other formats not commonly supported by Github
-	} else {
-		fmt.Errorf("protocol format is not supported: %s", protocol)
+	default:
+		_ = fmt.Errorf("protocol format is not supported: %s", protocol)
 		return ""
 	}
 
 	return d[1] + "/" + repoPath
 }
 
 // Extract array of string from urlString
-func getUrlStringArray(urlString string) []string {
+func getURLStringArray(urlString string) []string {
 	// Supported git regex based on URI allowed regex as defined under RFC3986
-	re, err := regexp.Compile(`[A-Za-z0-9][A-Za-z0-9+.-]*`)
-	if err != nil {
-		fmt.Errorf("error when parsing regex: %q", err.Error())
-	}
+	const rfc3986 = `[A-Za-z0-9][A-Za-z0-9+.-]*`
+	re := regexp.MustCompile(rfc3986)
 	var u []string = re.FindAllString(urlString, -1)
 	return u
 }