Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GitHub Icons hard to see in Dark Mode #10

Open
vikasganiga05 opened this issue Mar 29, 2021 · 0 comments
Open

[BUG] GitHub Icons hard to see in Dark Mode #10

vikasganiga05 opened this issue Mar 29, 2021 · 0 comments

Comments

@vikasganiga05
Copy link

vikasganiga05 commented Mar 29, 2021

Hi 👋 , The GitHub icons on the README.md file are hard to see on GitHub's dark theme. It looks clearly in light theme.

Dark Mode ScreenShot

I found a solution

Apply the below changes to all the github icons images.

- <img alt="source code" width="18px;" src="./thumbnails/github_icon.png" />
+ <img width="18px" src="https://user-images.githubusercontent.com/3369400/139447912-e0f43f33-6d9f-45f8-be46-2df5bbc91289.png#gh-dark-mode-only" />
+ <img width="18px" src="https://user-images.githubusercontent.com/3369400/139448065-39a229ba-4b06-434b-bc67-616e2ed80c8f.png#gh-light-mode-only" />

Preview

It will change GitHub image according to the GitHub theme your set. 👇
Want to know more click here -> Specify theme context for images in Markdown

image

@vikasganiga05 vikasganiga05 changed the title GitHub Icons hard to see in Dark Mode [BUG] GitHub Icons hard to see in Dark Mode Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant