Makes cargo clippy happy.

Author: Lichtso

.github/workflows/main.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest, ubuntu-latest, windows-latest]
-        rust: [stable, beta, nightly]
+        rust: [stable, beta]
     steps:
     - uses: actions/checkout@v1
     - name: Setup Rust (rustup)
@@ -31,7 +31,7 @@ jobs:
       run: |
         cargo fmt --all -- --check
         cargo clippy --all --tests -- --deny=warnings
-      if: matrix.rust == 'nightly'
+      if: matrix.rust == 'beta'
       shell: bash
     - name: Build and test
       run: |
@@ -45,7 +45,7 @@ jobs:
       run: |
         cargo fmt --all --manifest-path cli/Cargo.toml -- --check
         cargo clippy --all --tests --manifest-path cli/Cargo.toml -- --deny=warnings
-      if: matrix.rust == 'nightly'
+      if: matrix.rust == 'beta'
       shell: bash
     - name: CLI - Build and test
       run: |
@@ -58,11 +58,11 @@ jobs:
         export RUSTFLAGS="-D warnings"
         cargo install cargo-fuzz
         cargo fuzz build
-      if: matrix.rust == 'nightly' && matrix.os != 'windows-latest'
+      if: matrix.rust == 'beta' && matrix.os != 'windows-latest'
       shell: bash
     - name: Benchmark
       run: RUSTFLAGS="-D warnings" cargo bench -- --nocapture
-      if: matrix.rust == 'nightly' && matrix.os != 'windows-latest'
+      if: matrix.rust == 'beta' && matrix.os != 'windows-latest'
       shell: bash
 
   coverage:

clippy.toml

@@ -89,7 +89,7 @@ impl<I: Instruction> IntoBytes for &I {
     fn into_bytes(self) -> Self::Bytes {
         vec![
             self.opt_code_byte(),
-            self.get_src() << 4 | self.get_dst(),
+            (self.get_src() << 4) | self.get_dst(),
             self.get_off() as u8,
             (self.get_off() >> 8) as u8,
             self.get_imm() as u8,

src/insn_builder.rs

@@ -1365,7 +1365,7 @@ impl<'a, C: ContextObject> JitCompiler<'a, C> {
             }
         }
 
-        self.emit_ins(X86Instruction::alu_immediate(size, 0xf7, 0x4 | (division as u8) << 1 | signed as u8, REGISTER_SCRATCH, 0, None));
+        self.emit_ins(X86Instruction::alu_immediate(size, 0xf7, 0x4 | ((division as u8) << 1) | signed as u8, REGISTER_SCRATCH, 0, None));
 
         if dst != RDX {
             if alt_dst {