Skip to content

Commit eef0b8e

Browse files
authored
sdk: Remove dummy-for-ci-check feature (#7)
#### Problem The `dummy-for-ci-check` feature was added to avoid breaking Agave's CI when the sdk was put into its own workspace, but it isn't actually needed by `solana-sdk` now that it's out of the Agave repo. #### Summary of changes Remove the feature everywhere.
1 parent 7a53f37 commit eef0b8e

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

scripts/check-clippy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ cd "${src_root}"
1515
# the bench itself isn't stabilized yet...
1616
# ref: https://github.com/rust-lang/rust/issues/66287
1717
./cargo nightly clippy \
18-
--workspace --all-targets --features dummy-for-ci-check,frozen-abi -- \
18+
--workspace --all-targets --features frozen-abi -- \
1919
--deny=warnings \
2020
--deny=clippy::default_trait_access \
2121
--deny=clippy::arithmetic_side_effects \

scripts/check-nightly.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ here="$(dirname "$0")"
55
src_root="$(readlink -f "${here}/..")"
66
cd "${src_root}"
77

8-
./cargo nightly check --locked --workspace --all-targets --features dummy-for-ci-check,frozen-abi
8+
./cargo nightly check --locked --workspace --all-targets --features frozen-abi

sdk/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ license = { workspace = true }
1111
edition = { workspace = true }
1212

1313
[features]
14-
# Needed by the monorepo for checks in CI, can be removed when the SDK is
15-
# extracted
16-
dummy-for-ci-check = []
1714
# "program" feature is a legacy feature retained to support v1.3 and older
1815
# programs. New development should not use this feature. Instead use the
1916
# solana-program crate

0 commit comments

Comments
 (0)