Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS AN aodn developer I WANT to investigate the weird output SO THAT they are not confusing #195

Open
4 tasks
HavierD opened this issue Oct 11, 2024 · 2 comments

Comments

@HavierD
Copy link
Contributor

HavierD commented Oct 11, 2024

Acceptance Criteria

  1. solve the problem mentioned in task list
  2. It is a low priority ticket.

Notes

  1. Currently, the playwright test output has error "Must provide a proper URL as target". (more information will put in comment). Could you please investigate it:

Tasks

PRs

Dependencies

Demo

@HavierD
Copy link
Contributor Author

HavierD commented Oct 11, 2024

VITE v5.4.8 ready in 346 ms
web-1 |
web-1 | ➜ Local: http://localhost:5173/
web-1 | ➜ Network: http://172.18.0.2:5173/
tests-1 | Server started successfully
tests-1 | ============================= test session starts ==============================
tests-1 | platform linux -- Python 3.10.12, pytest-8.2.2, pluggy-1.5.0
tests-1 | rootdir: /app
tests-1 | configfile: pytest.ini
tests-1 | plugins: metadata-3.1.1, html-4.1.1, base-url-2.1.0, xdist-3.6.1, playwright-0.4.4
tests-1 | collected 18 items
tests-1 |
web-1 | 2:35:48 AM [vite] page reload playwright/reports/test-report.html
tests-1 | tests/detail_page/test_about_tab.py . [ 5%]
tests-1 | tests/detail_page/test_associated_records_tab.py . [ 11%]
tests-1 | tests/detail_page/test_citation_tab.py . [ 16%]
web-1 | 2:36:26 AM [vite] http proxy error: Must provide a proper URL as target
web-1 | Error: Must provide a proper URL as target
web-1 | at ProxyServer. (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61274:36)
web-1 | at viteProxyMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61605:15)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at viteCachedTransformMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61738:5)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at cors (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41792:7)
web-1 | at file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41828:17
web-1 | at originCallback (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41818:15)
web-1 | 2:36:26 AM [vite] http proxy error: Must provide a proper URL as target
web-1 | Error: Must provide a proper URL as target
web-1 | at ProxyServer. (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61274:36)
web-1 | at viteProxyMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61605:15)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at viteCachedTransformMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61738:5)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at cors (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41792:7)
web-1 | at file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41828:17
web-1 | at originCallback (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41818:15)
web-1 | 2:36:29 AM [vite] http proxy error: Must provide a proper URL as target
web-1 | Error: Must provide a proper URL as target
web-1 | at ProxyServer. (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61274:36)
web-1 | at viteProxyMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61605:15)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at viteCachedTransformMiddleware (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:61738:5)
web-1 | at call (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41320:7)
web-1 | at next (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41264:5)
web-1 | at cors (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41792:7)
web-1 | at file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41828:17
web-1 | at file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41828:17
web-1 | at originCallback (file:///app/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:41818:15)
tests-1 | tests/search/test_search.py .. [100%]
tests-1 |

@HavierD HavierD changed the title AS AN aodn developer I WANT to fix the weird issue SO THAT the playwright test is stable AS AN aodn developer I WANT to investigate the weird output SO THAT they are not confusing Oct 11, 2024
@AR-RIFAT
Copy link
Collaborator

@HavierD If you run the web server without specifying a value for VITE_API_HOST in the .env file, these errors are shown when the website makes any API request. Similarly, in the GitHub workflow, there is no .env file, which results in errors.

In UI tests, this should not be an issue, as all API requests are mocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants