AMQ-XX: Fix long running KahaDBOffsetRecoveryListenerTest on CI #1555
+12
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taking about an hour to run.
The @before code is running every single time for all the test scenario of the class.
I'm questioning what the benefit of the @before peace of code. If it's an actual test, I'd pull it into its own @test method.
But for now, it's burning a lot of time because it does a lot of IO and the CI is slow for IO. Moreover, the directory used in the sendMessage call of the @before portion is the default one, because the broker is lazily created after using the VM Transport, whereas all the other tests are actually using a different directory.
Locally on my Mac M1 it runs on 16 min and after the removal, it runs in 2'30.
If everyone is happy with it, I can create a JIRA and rename this PR and update the commit message