Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sphinx to version 7 to improve documentation errors #31963

Open
1 task done
potiuk opened this issue Jun 16, 2023 · 0 comments
Open
1 task done

Upgrade Sphinx to version 7 to improve documentation errors #31963

potiuk opened this issue Jun 16, 2023 · 0 comments
Labels
kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Jun 16, 2023

Body

We should upgrade Sphinx to version 7

Sphinx 6 has known issues with informing about various errors in our documentation and it becomes REALLY painful. Quite often contributors are mind-boggled by the errors in their documentation after they have done apparently and innocent change. Even super-experienced engineers have hard time figuring out what the error really is and often we have to revert to some woodo-like practices like bisecting in order to narrow down and fix the problems.

Recent examples of such problems which caused us hours of debugging are :

What holds us freom migration though is the lack of support for sphinx 7 in the sphinx_rtd-theme which we are using as the base for airflow theme. We build and publish our theme in https://github.com/apache/airflow-site and the sphinx_rtd_theme issue is:

There are three ways how this can be solved:

  1. make sphinx_rtd_theme release sphinx7 theme and switch to it
  2. vendor in sphinx_rtd_theme into airlfow theme and make necessary changes to support sphinx7
  3. switch to another theme.
  4. Possibly also switch to sphinx.ext.autodoc from autoapi

If 1) cannot be achieved, seems that 2) might be the easiest one to achieve it.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Jun 16, 2023
kaxil added a commit to astronomer/airflow that referenced this issue May 6, 2024
closes apache#31963

All the linked issues on the above have been resolved
kaxil added a commit to astronomer/airflow that referenced this issue May 6, 2024
closes apache#31963

All the linked issues on the above have been resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant