Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on July 09, 2024 #40661

Closed
34 of 52 tasks
eladkal opened this issue Jul 9, 2024 · 33 comments
Closed
34 of 52 tasks

Status of testing Providers that were prepared on July 09, 2024 #40661

eladkal opened this issue Jul 9, 2024 · 33 comments
Labels
area:providers kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Jul 9, 2024

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

The guidelines on how to test providers can be found in

Verify providers by contributors

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 8.26.0rc1

Provider cncf.kubernetes: 8.3.3rc1

Provider common.sql: 1.14.2rc1

Provider databricks: 6.7.0rc1

Provider docker: 3.12.2rc1

Provider fab: 1.2.1rc1

Provider google: 10.21.0rc1

Provider influxdb: 2.6.0rc1

Provider microsoft.azure: 10.2.0rc1

Provider openlineage: 1.9.1rc1

Provider oracle: 3.10.3rc1

Provider snowflake: 5.6.0rc1

Provider teradata: 2.4.0rc1

Provider weaviate: 2.0.0rc1

Provider ydb: 1.1.0rc1

All users involved in the PRs:
@BenediktRamsauer @marcel-martinelli @kacpermuda @uzhastik @jsjasonseba @antoinetavant @theopus @CYarros10 @sc250072 @MaksYermak @boraberke @guillaumeblaquiere @o-nikolas @Lee-W @shahar1 @potiuk @ellism

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Jul 9, 2024
@potiuk
Copy link
Member

potiuk commented Jul 9, 2024

I checked all my changes they look good. One SMALL thing.. I noticed that weaviate changelog is wrong - the 2.0.0 changelog contains also 1.4.2 changes and 1.4.2 is missing from changelog. This is caused by #40194 - where 2.0.0 description replaced 1.4.2 one rather than added it. This should not change the release status of 2.0.0 because changelog is not part of the package and we can fix it by cherry-picking #40663 that fixes it and reganerating the documentation (cc: @eladkal )

@kacpermuda
Copy link
Contributor

I checked all my changes they look good. Thanks !

@sc250072
Copy link
Contributor

sc250072 commented Jul 9, 2024

I checked Teradata airflow provider and new feature(s) are working as expected. Thank you!.

@MaksYermak
Copy link
Contributor

I have checked all my changes they work as expected.

@vanducng
Copy link
Contributor

vanducng commented Jul 9, 2024

I checked my change for the snowflake provider, it works as expected.

@eladkal
Copy link
Contributor Author

eladkal commented Jul 9, 2024

Weaviate provider will have rc2

@marcel-martinelli
Copy link
Contributor

I checked all my changes on the Databricks operator; it works fine!

@gopidesupavan
Copy link
Member

Verified #40492 and #40504 are working fine. Thank you for the release efforts.

@dirrao
Copy link
Contributor

dirrao commented Jul 10, 2024

I have verified #40629 and #40506. They are working as expected.

@antoinetavant
Copy link
Contributor

I have verified the Docker operator, both #39620 and #40489 works as expected on airflow:2.8.3-python3.11 as well as airflow:2.9.2-python3.11

@BenediktRamsauer
Copy link
Contributor

I have tested #40642 and it is working.

@guillaumeblaquiere
Copy link
Contributor

Ok for #40560

@uzhastik
Copy link
Contributor

OK for ydb provider and #40390

@potiuk
Copy link
Member

potiuk commented Jul 10, 2024

I am not sure if that qualifies for RC2, but currently in main AWS auth manager fails compatibility test for 2.8 - i described it in #40684 - cc: @vincbeck, @eladkal

@potiuk
Copy link
Member

potiuk commented Jul 10, 2024

So I guess with #40690 it means RC2 for Amazon @vincbeck ?

@vincbeck
Copy link
Contributor

Yes!

@eladkal
Copy link
Contributor Author

eladkal commented Jul 10, 2024

You wish to exclude fab or amazon from rc1?

Amazon provider will be excluded from rc1

@anteverse
Copy link
Contributor

#40518

Checked and working as expected.

@shahar1
Copy link
Contributor

shahar1 commented Jul 10, 2024

#40479 is ok

@jscheffl
Copy link
Contributor

jscheffl commented Jul 10, 2024 via email

@jscheffl
Copy link
Contributor

jscheffl commented Jul 10, 2024 via email

@jscheffl
Copy link
Contributor

Ah, emails are getting to ticket and not to devlist :-D

As far as I see the PR #40153 is not in the providers-cut? Then it is OK...

@pankajkoti
Copy link
Member

yes, #40153 is not in this providers wave

@dabla
Copy link
Contributor

dabla commented Jul 11, 2024

PR 40615 partially fixes the issue, it doesn't fix it for the JdbcHook as there the driver_path and driver_class property causes the same issue as placeholder did. Also mentioned this in original issue.

@potiuk
Copy link
Member

potiuk commented Jul 11, 2024

PR 40615 partially fixes the issue, it doesn't fix it for the JdbcHook as there the driver_path and driver_class property causes the same issue as placeholder did. Also mentioned this in original issue.

Yeah. Good catch @dabla -> I think it's not a blocker for this release, it's not a regression comparing to already released common.sql and we can always fix it in the next round (and it has rather small-ish impact).

@eladkal
Copy link
Contributor Author

eladkal commented Jul 12, 2024

@dabla can you raise PR with a fix for it?

@dabla
Copy link
Contributor

dabla commented Jul 12, 2024

@dabla can you raise PR with a fix for it?

Hey Elad, yes I already have a fix for it, but would like to see PR #40665 merged first as this will allow me to have a cleaner solution. Unless you want this fix first then I will have to refactor the fix in #40665 afterwards, that's also possible. It's up to you

@potiuk
Copy link
Member

potiuk commented Jul 12, 2024

I think it's not a regression and can be easily fixed in the next round if you ask me :) - there are few other things that @dabla is contributing in this area #40665 and likely they could be done in next release ?

@potiuk
Copy link
Member

potiuk commented Jul 12, 2024

Similar answer :)

@dabla
Copy link
Contributor

dabla commented Jul 12, 2024

Same for me, if you want the fix @eladkal, it can be done now/today...

@dabla
Copy link
Contributor

dabla commented Jul 12, 2024

I already started with the PR for this fix, can merge #40665 afterwards, not such a big issue anyway

@eladkal
Copy link
Contributor Author

eladkal commented Jul 12, 2024

Thank you everyone. Providers are released (excluding amazon and weaviate)

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@eladkal eladkal closed this as completed Jul 12, 2024
@dabla
Copy link
Contributor

dabla commented Jul 12, 2024

@dabla can you raise PR with a fix for it?

#40751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests