Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: As a user, I want to see a log message after apisix.yml config reload in standalone mode, so that I know if everything went fine #10402

Closed
markokocic opened this issue Oct 26, 2023 · 1 comment · Fixed by #10404
Closed

feat: As a user, I want to see a log message after apisix.yml config reload in standalone mode, so that I know if everything went fine #10402

markokocic opened this issue Oct 26, 2023 · 1 comment · Fixed by #10404
Labels
good first issue Good for newcomers

Comments

@markokocic
Copy link
Contributor

markokocic commented Oct 26, 2023 •
edited
Loading

Description

feat: As a user, I want to see a log message after apisix.yml config reload in standalone mode, so that I know if everything went fine.

Right now, only errors are logged in case apisix.yml reload fails. There's no indication of sucesful re-loading. Having a success log message would help to confirm when the new configuration is applied after reload.
@markokocic markokocic changed the title feat: As a user, I want to see a log message after apisix.yml config reload in standalone, so that I know if everything went fine feat: As a user, I want to see a log message after apisix.yml config reload in standalone mode, so that I know if everything went fine Oct 26, 2023
markokocic added a commit to markokocic/apisix that referenced this issue Oct 26, 2023
@markokocic
Add log message after apisix.yml config reload
214322d 
Fixes apache#10402

Please review. Not sure why is the log message printed multiple times and how to avoid it.
@markokocic markokocic mentioned this issue Oct 26, 2023
Merged
5 tasks
@shreemaan-abhishek shreemaan-abhishek added the good first issue Good for newcomers label Oct 27, 2023
@kayx23
Copy link
Member

kayx23 commented Dec 2, 2023

Closing as the change was evaluated to be unnecessary in #10404

@kayx23 kayx23 closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Apache APISIX backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: add log after apisix.yml config reload in standalone mode markokocic/apisix
3 participants
@markokocic @kayx23 @shreemaan-abhishek