-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Bump version of bundled AWS SDK #20272
Comments
@pitrou should the 1.9 AWS SDK version be possible now? From my understanding our conda forge recipes use:
|
Yes, it should be. Unfortunately, it might require bumping all AWS-related dependencies, or perhaps even adding some of them. cc @kou |
I can't work on this right now but I can help a person who wants to work on this. |
@js8544 Certainly not. It's more a matter of finding out (or discovering) what has or has not changed in the AWS SDK build procedures between 1.8.x and 1.9.x. @h-vetinari Might know a bit about that? |
Okay. I'll try to work on this. I noticed that aws sdk cpp has published version 1.10(https://github.com/aws/aws-sdk-cpp#version-110-is-now-available). Do we want to update to 1.10 or 1.9? |
If 1.10 works then let's go for it. |
take |
AFAIU, the aws-sdk-cpp bundles everything you need (for AWS), I don't think anything else depends on it.
Biggest (only?) issue that blocked upgrading to 1.9 was https://issues.apache.org/jira/browse/ARROW-15141 due to aws/aws-sdk-cpp#1809. That has been fixed through awslabs/aws-c-io#515, and once we had a 1.9 build with that (conda-forge unbundles the sdk into separate parts, so it's a bit of a different situation), we were able to bump to 1.9. I have been thinking about bumping the conda-forge feedstock to 1.10, but we haven't actually done that yet, and there's been a couple changes being advertised in the upstream readme. I think we'd have to test whether this works. The good thing is that the arrow CI also contains a working simile of the conda-feedstock CI, and it would be easy to test this for whatever PR is in the works by replacing the version pins in the CI yaml files here. |
### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. * Closes: #20272 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. * Closes: apache#20272 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. * Closes: apache#20272 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. * Closes: apache#20272 Lead-authored-by: Jin Shang <shangjin1997@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
The latest version on the 1.8 line is 1.8.186.
We could also try to switch to the 1.9 line, but there were blocking issues last time we tried.
Note we should bump the dependent AWS library versions at the same time.
Reporter: Antoine Pitrou / @pitrou
Note: This issue was originally created as ARROW-16727. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: