Skip to content

Commit 6d7a434

Browse files
committed
Revert unnecessary fixes in tests
1 parent 66e2565 commit 6d7a434

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ public void testPublishingThenReadingAll() throws IOException, JMSException {
215215
int unackRecords = countRemain(QUEUE);
216216
assertTrue(
217217
String.format("Too many unacknowledged messages: %d", unackRecords),
218-
unackRecords < OPTIONS.getNumberOfRecords() * 0.005);
218+
unackRecords < OPTIONS.getNumberOfRecords() * 0.003);
219219

220220
// acknowledged records
221221
int ackRecords = OPTIONS.getNumberOfRecords() - unackRecords;

sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -660,9 +660,6 @@ private JmsIO.UnboundedJmsReader setupReaderForTest() throws JMSException {
660660
final int delay = 10;
661661
return connectorClass == JmsConnectionFactory.class
662662
? (JmsTextMessage message) -> {
663-
if (message == null) {
664-
return null;
665-
}
666663
final JmsAcknowledgeCallback originalCallback = message.getAcknowledgeCallback();
667664
JmsAcknowledgeCallback jmsAcknowledgeCallbackMock =
668665
Mockito.mock(JmsAcknowledgeCallback.class);
@@ -682,9 +679,6 @@ private JmsIO.UnboundedJmsReader setupReaderForTest() throws JMSException {
682679
return message;
683680
}
684681
: (ActiveMQMessage message) -> {
685-
if (message == null) {
686-
return null;
687-
}
688682
final Callback originalCallback = message.getAcknowledgeCallback();
689683
message.setAcknowledgeCallback(
690684
() -> {

0 commit comments

Comments
 (0)