[ErrorProne] Resolve Error Prone NonCanonicalType warnings across the codebase

[stankiewicz]

This PR removes the NonCanonicalType warning from the disabledChecks Error Prone configuration in BeamModulePlugin.groovy
and fixes the resulting codebase violations - updating code to refer to canonical types directly rather than resolving them via sub-classes or enclosing classes

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code quality by resolving Error Prone NonCanonicalType warnings across the codebase. It involves removing a specific warning from the Error Prone configuration and updating the code to directly reference canonical types, enhancing code maintainability and reducing potential errors.

Highlights

• ErrorProne Fixes: This PR addresses Error Prone NonCanonicalType warnings by updating code to refer to canonical types directly.
• Configuration Update: The NonCanonicalType warning is removed from the disabledChecks Error Prone configuration in BeamModulePlugin.groovy.
• Codebase Adjustments: Codebase violations resulting from the Error Prone configuration change are fixed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity

• The PR removes the NonCanonicalType warning from the disabledChecks Error Prone configuration in BeamModulePlugin.groovy.
• The PR fixes codebase violations by updating code to refer to canonical types directly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[stankiewicz]

Run Java_GCP_IO_Direct PreCommit

[stankiewicz]

/gemini review

[stankiewicz]

Run Java PreCommit

[gemini-code-assist]

Code Review

This pull request resolves Error Prone's NonCanonicalType warnings across the codebase by updating references to nested types to use their canonical forms. The changes are consistent and correct, replacing non-canonical type references with their direct, canonical counterparts. This improves code clarity and adheres to best practices. The modifications span several modules and consistently apply the same fix pattern. I've reviewed the changes and found no issues.

[stankiewicz]

assign set of reviewers

[gemini-code-assist]

Code Review

This pull request addresses NonCanonicalType warnings from Error Prone across the codebase. The changes consistently replace non-canonical type references with their canonical forms, such as referring to nested types through their defining class rather than a subclass. This is a valuable code health improvement that increases clarity and consistency. The changes appear correct and I have no further suggestions.

[github-actions]

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).