Skip to content

Cherrypick #37642#37807

Merged
Amar3tto merged 1 commit intorelease-2.72from
cp-37642
Mar 10, 2026
Merged

Cherrypick #37642#37807
Amar3tto merged 1 commit intorelease-2.72from
cp-37642

Conversation

@Amar3tto
Copy link
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto Amar3tto requested a review from Abacn March 10, 2026 15:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a cherry-pick of changes primarily focused on maintaining the frontend Playground components. It updates several Dart package dependencies to ensure the application uses compatible and stable versions. Additionally, it addresses a known issue by temporarily disabling a failing UI integration test related to a null assertion, with a clear reference to the tracking issue. The PR also includes a minor adjustment to test logic for analytics events, allowing for more flexible event type assertions.

Highlights

  • Dependency Updates: Updated several Flutter/Dart package dependencies, including app_state, easy_localization, and keyed_collection_widgets, to specific versions or version ranges across multiple pubspec.yaml files to ensure compatibility and stability.
  • Integration Test Management: Temporarily disabled a failing integration test (integrationTest_standalone_miscellaneous_ui) in build.gradle and added a TODO comment referencing an issue for a null assertion fix.
  • Analytics Event Handling: Refined the analytics event expectation logic in widget_tester.dart to correctly handle both RunFinishedAnalyticsEvent and RunStartedAnalyticsEvent, improving test robustness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • playground/frontend/build.gradle
  • playground/frontend/integration_test/embedded_run_test.dart
    • Reordered the checkToggleBrightnessMode call to occur before runExpectCached.
  • playground/frontend/playground_components/pubspec.yaml
    • Updated app_state dependency from ^0.9.3 to 0.9.4.
    • Updated easy_localization dependency from ^3.0.1 to ">=3.0.1 <3.0.3".
    • Updated keyed_collection_widgets dependency from ^0.4.3 to 0.4.3.
  • playground/frontend/playground_components_dev/lib/src/widget_tester.dart
    • Modified the expectRunFinished method to check for both RunFinishedAnalyticsEvent and RunStartedAnalyticsEvent.
    • Added a fail condition for unexpected analytics events.
  • playground/frontend/playground_components_dev/pubspec.yaml
    • Updated app_state dependency from ^0.9.3 to 0.9.4.
    • Updated keyed_collection_widgets dependency from ^0.4.3 to 0.4.3.
  • playground/frontend/pubspec.yaml
    • Updated app_state dependency from ^0.9.4 to 0.9.4.
    • Updated easy_localization dependency from ^3.0.1 to ">=3.0.1 <3.0.3".
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Amar3tto Amar3tto merged commit 88abd81 into release-2.72 Mar 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants