From 7850f4eee5de84e8195bbee0504767545c398bd2 Mon Sep 17 00:00:00 2001 From: Radek Stankiewicz Date: Wed, 4 Mar 2026 19:36:22 +0100 Subject: [PATCH] Fix UnusedVariable warnings across codebase --- .../beam/gradle/BeamModulePlugin.groovy | 1 - ...edSplittableProcessElementInvokerTest.java | 8 +++-- ...SimplePushbackSideInputDoFnRunnerTest.java | 3 +- .../core/SplittableParDoProcessFnTest.java | 17 ++++++---- .../beam/runners/direct/DirectMetrics.java | 4 ++- ...ManagerRemovingTransformEvaluatorTest.java | 2 +- .../direct/DoFnLifecycleManagerTest.java | 2 +- .../direct/DoFnLifecycleManagersTest.java | 4 +-- .../UnboundedReadEvaluatorFactoryTest.java | 3 ++ .../flink/FlinkExecutionEnvironments.java | 2 -- .../ExecutableStageDoFnOperator.java | 4 +-- .../runners/flink/ReadSourcePortableTest.java | 2 ++ .../DataflowPipelineTranslatorTest.java | 6 ++-- .../dataflow/worker/status/DebugCapture.java | 2 ++ .../worker/DefaultParDoFnFactoryTest.java | 2 +- .../worker/DoFnInstanceManagersTest.java | 3 +- .../worker/WorkerCustomSourcesTest.java | 1 + .../PortablePipelineJarCreatorTest.java | 4 +-- .../ParDoBoundMultiTranslator.java | 2 +- .../beam/sdk/schemas/transforms/Select.java | 7 ++--- .../beam/sdk/coders/CoderRegistryTest.java | 4 +-- .../options/PipelineOptionsFactoryTest.java | 3 +- .../options/ProxyInvocationHandlerTest.java | 1 + .../beam/sdk/schemas/utils/JsonUtilsTest.java | 2 ++ .../beam/sdk/transforms/DoFnTesterTest.java | 2 +- .../apache/beam/sdk/transforms/WaitTest.java | 2 +- .../transforms/display/DisplayDataTest.java | 2 +- .../reflect/DefaultPackageTest.java | 2 +- .../DoFnSignaturesSplittableDoFnTest.java | 12 ++++--- .../PTransformReplacementsTest.java | 2 +- .../PTransformTranslationTest.java | 2 +- .../construction/ParDoTranslationTest.java | 21 ++++++++----- .../construction/PipelineTranslationTest.java | 2 +- .../construction/SplittableParDoTest.java | 12 ++++--- .../graph/FieldAccessVisitorTest.java | 7 +++-- .../graph/ProjectionProducerVisitorTest.java | 2 +- .../ProjectionPushdownOptimizerTest.java | 5 +-- .../graph/QueryablePipelineTest.java | 2 +- .../expansion/service/ExpansionService.java | 2 +- .../extensions/avro/coders/AvroCoderTest.java | 2 ++ .../beam/sdk/extensions/sql/impl/nfa/NFA.java | 31 +++---------------- .../sql/impl/rel/BeamEnumerableConverter.java | 2 +- .../sql/impl/rel/BeamWindowRel.java | 10 ++++-- .../impl/rel/BeamEnumerableConverterTest.java | 2 +- .../apache/beam/sdk/io/datadog/DatadogIO.java | 2 -- .../sdk/io/elasticsearch/ElasticsearchIO.java | 2 +- ...ReadSchemaTransformFormatProviderTest.java | 8 ++--- .../gcp/bigquery/UpdateSchemaDestination.java | 11 ++----- .../beam/sdk/io/gcp/bigquery/WriteTables.java | 2 +- ...torageWriteApiSchemaTransformProvider.java | 4 +-- .../PubsubReadSchemaTransformProvider.java | 2 +- .../beam/sdk/io/gcp/spanner/SpannerIO.java | 5 --- .../SpannerWriteSchemaTransformProvider.java | 4 +-- .../bigquery/BigQueryIOStorageReadTest.java | 5 ++- .../dao/ChangeStreamResultSetTest.java | 1 - .../org/apache/beam/sdk/io/hbase/HBaseIO.java | 4 +-- .../io/iceberg/WriteDirectRowsToFiles.java | 2 +- .../JdbcWriteSchemaTransformProvider.java | 2 +- .../org/apache/beam/sdk/io/jdbc/JdbcIOIT.java | 3 +- .../apache/beam/sdk/io/kafka/KafkaIOIT.java | 1 + .../org/apache/beam/sdk/io/kudu/KuduIO.java | 6 ++-- .../beam/sdk/io/pulsar/PulsarIOUtils.java | 3 -- .../beam/sdk/io/pulsar/PulsarIOTest.java | 3 -- .../sdk/io/singlestore/SingleStoreIO.java | 5 +-- .../inference/remote/RemoteInferenceTest.java | 18 ++++------- .../sdk/testing/TestPipelineExtension.java | 1 - .../testutils/metrics/MetricsReaderTest.java | 2 +- 67 files changed, 154 insertions(+), 155 deletions(-) diff --git a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy index d9f3de5ea766..a3b712f69aef 100644 --- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy +++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy @@ -1587,7 +1587,6 @@ class BeamModulePlugin implements Plugin { "StringCharset", "SuperCallToObjectMethod", "UnnecessaryLongToIntConversion", - "UnusedVariable", // intended suppressions emerged in newer protobuf versions "AutoValueBoxedValues", // For backward compatibility. Public method checked in before this check impl diff --git a/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java b/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java index 8b2b83b4d9a3..1750cceffa0e 100644 --- a/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java +++ b/runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java @@ -90,7 +90,7 @@ public ProcessContinuation process( } @GetInitialRestriction - public OffsetRange getInitialRestriction(@Element Void element) { + public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Void element) { throw new UnsupportedOperationException("Should not be called in this test"); } } @@ -209,7 +209,8 @@ public void process(ProcessContext c, RestrictionTracker trac } @GetInitialRestriction - public OffsetRange getInitialRestriction(@Element Void element) { + public OffsetRange getInitialRestriction( + @SuppressWarnings("unused") @Element Void element) { throw new UnsupportedOperationException("Should not be called in this test"); } }; @@ -228,7 +229,8 @@ public void process(ProcessContext c, RestrictionTracker trac } @GetInitialRestriction - public OffsetRange getInitialRestriction(@Element Void element) { + public OffsetRange getInitialRestriction( + @SuppressWarnings("unused") @Element Void element) { throw new UnsupportedOperationException("Should not be called in this test"); } }; diff --git a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java index 9703c3c80bd1..1ae937b7a836 100644 --- a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java +++ b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimplePushbackSideInputDoFnRunnerTest.java @@ -536,7 +536,8 @@ private static class MyDoFn extends DoFn, Integer> { public final StateSpec> intState = StateSpecs.value(VarIntCoder.of()); @ProcessElement - public void processElement(ProcessContext c, @StateId(stateId) ValueState state) { + public void processElement( + @SuppressWarnings("unused") ProcessContext c, @StateId(stateId) ValueState state) { Integer currentValue = MoreObjects.firstNonNull(state.read(), 0); state.write(currentValue + 1); } diff --git a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java index 3aebe2840a9f..268501b7ee75 100644 --- a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java +++ b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java @@ -287,7 +287,8 @@ public void process(ProcessContext c, RestrictionTracker } @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer elem) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer elem) { return new SomeRestriction(); } } @@ -342,7 +343,7 @@ public void process( } @GetInitialRestriction - public OffsetRange getInitialRestriction(@Element Instant elem) { + public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Instant elem) { throw new IllegalStateException("Expected to be supplied explicitly in this test"); } @@ -402,7 +403,8 @@ public ProcessContinuation process( } @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer elem) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer elem) { return new SomeRestriction(); } } @@ -465,7 +467,7 @@ public ProcessContinuation process( } @GetInitialRestriction - public OffsetRange getInitialRestriction(@Element Integer elem) { + public OffsetRange getInitialRestriction(@SuppressWarnings("unused") @Element Integer elem) { throw new UnsupportedOperationException("Expected to be supplied explicitly in this test"); } } @@ -586,12 +588,15 @@ private enum State { private State state = State.BEFORE_SETUP; @ProcessElement - public void process(ProcessContext c, RestrictionTracker tracker) { + public void process( + @SuppressWarnings("unused") ProcessContext c, + @SuppressWarnings("unused") RestrictionTracker tracker) { assertEquals(State.INSIDE_BUNDLE, state); } @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer element) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer element) { return new SomeRestriction(); } diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java index 17b412349ea3..b7cf0357447a 100644 --- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java +++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java @@ -142,7 +142,9 @@ public ResultT extractLatestAttempted() { * @param bundle The bundle being committed. * @param finalCumulative The final cumulative value for the given bundle. */ - public void commitLogical(final CommittedBundle bundle, final UpdateT finalCumulative) { + public void commitLogical( + @SuppressWarnings("unused") final CommittedBundle bundle, + final UpdateT finalCumulative) { UpdateT current; do { current = finishedCommitted.get(); diff --git a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java index 53c02e796002..39bcd5ae7f80 100644 --- a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java +++ b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluatorTest.java @@ -144,6 +144,6 @@ public void removesOnExceptionInFinishBundle() throws Exception { private static class TestFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) throws Exception {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {} } } diff --git a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java index fc019b708c4b..3963131ec6d3 100644 --- a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java +++ b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagerTest.java @@ -219,7 +219,7 @@ public void setup() { } @ProcessElement - public void processElement(ProcessContext c) throws Exception {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {} @Teardown public void teardown() { diff --git a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java index 49a4023b3b74..7a789b06a6f0 100644 --- a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java +++ b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/DoFnLifecycleManagersTest.java @@ -111,7 +111,7 @@ private ThrowsInCleanupFn(String message) { } @ProcessElement - public void processElement(ProcessContext c) throws Exception {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {} @Teardown public void teardown() throws Exception { @@ -165,6 +165,6 @@ public void describeTo(Description description) { private static class EmptyFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) throws Exception {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) throws Exception {} } } diff --git a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactoryTest.java b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactoryTest.java index 5413a694e92b..1f9eeb8a1d3b 100644 --- a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactoryTest.java +++ b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactoryTest.java @@ -496,7 +496,10 @@ private static class TestUnboundedSource extends UnboundedSource coder; private final List elems; private boolean dedupes = false; diff --git a/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java b/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java index 8b3b2ed9c960..937ca33232e4 100644 --- a/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java +++ b/runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java @@ -47,7 +47,6 @@ import org.apache.flink.configuration.StateBackendOptions; import org.apache.flink.configuration.TaskManagerOptions; import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings; -import org.apache.flink.runtime.state.StateBackend; import org.apache.flink.runtime.util.EnvironmentInformation; import org.apache.flink.streaming.api.CheckpointingMode; import org.apache.flink.streaming.api.environment.LocalStreamEnvironment; @@ -390,7 +389,6 @@ private static void configureCheckpointing( } private static void configureStateBackend(FlinkPipelineOptions options, Configuration config) { - final StateBackend stateBackend; if (options.getStateBackend() != null) { final String storagePath = options.getStateBackendStoragePath(); Preconditions.checkArgument( diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java index 2134fa869b47..4ebb359fceae 100644 --- a/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java +++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java @@ -1306,12 +1306,12 @@ private static void initializeUserState( private static class NoOpDoFn extends DoFn { @ProcessElement - public void doNothing(ProcessContext context) {} + public void doNothing(@SuppressWarnings("unused") ProcessContext context) {} } private static class StableNoOpDoFn extends DoFn { @RequiresStableInput @ProcessElement - public void doNothing(ProcessContext context) {} + public void doNothing(@SuppressWarnings("unused") ProcessContext context) {} } } diff --git a/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java b/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java index bf07fe4cafc2..edb6caee329e 100644 --- a/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java +++ b/runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java @@ -169,6 +169,7 @@ public UnboundedReader createReader( PipelineOptions options, @Nullable Checkpoint checkpointMark) { return new UnboundedReader() { + @SuppressWarnings("unused") int pos = -1; @Override @@ -230,6 +231,7 @@ public Coder getCheckpointMarkCoder() { } private static class Checkpoint implements CheckpointMark, Serializable { + @SuppressWarnings("unused") final int pos; Checkpoint(int pos) { diff --git a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java index 8226dc2c7274..6858aa031060 100644 --- a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java +++ b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java @@ -1690,12 +1690,14 @@ private static void assertAllStepOutputsHaveUniqueIds(Job job) throws Exception private static class TestSplittableFn extends DoFn { @ProcessElement - public void process(ProcessContext c, RestrictionTracker tracker) { + public void process( + @SuppressWarnings("unused") ProcessContext c, + @SuppressWarnings("unused") RestrictionTracker tracker) { // noop } @GetInitialRestriction - public OffsetRange getInitialRange(@Element String element) { + public OffsetRange getInitialRange(@SuppressWarnings("unused") @Element String element) { return null; } } diff --git a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java index c859b1071714..4c7c1736462c 100644 --- a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java +++ b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/DebugCapture.java @@ -79,11 +79,13 @@ public Page(String name, String content) { } // Implicitly read. Not a bug. + @SuppressWarnings("unused") @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD") @Key public String name; // Implicitly read. Not a bug. + @SuppressWarnings("unused") @SuppressFBWarnings("URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD") @Key public String content; diff --git a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java index 06138c02653b..976c9eda4762 100644 --- a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java +++ b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DefaultParDoFnFactoryTest.java @@ -63,7 +63,7 @@ private static class TestDoFn extends DoFn { } @ProcessElement - public void processElement(ProcessContext c) { + public void processElement(@SuppressWarnings("unused") ProcessContext c) { // This is called to ensure the SimpleParDoFn is fully initialized } } diff --git a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java index 7e53b1550263..006232da3e1c 100644 --- a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java +++ b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DoFnInstanceManagersTest.java @@ -48,7 +48,8 @@ private static class TestFn extends DoFn { boolean tornDown = false; @ProcessElement - public void processElement(ProcessContext processContext) throws Exception {} + public void processElement(@SuppressWarnings("unused") ProcessContext processContext) + throws Exception {} @Teardown public void teardown() throws Exception { diff --git a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java index 334b9414b26b..e51be59cc4e7 100644 --- a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java +++ b/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WorkerCustomSourcesTest.java @@ -239,6 +239,7 @@ public long getEstimatedSizeBytes(PipelineOptions options) { } private static class SourceWithLargeObject extends MockSource { + @SuppressWarnings("unused") byte[] array; public SourceWithLargeObject(int sourceObjectSize) { diff --git a/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java b/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java index 9296fcea3597..76dcc0563e7b 100644 --- a/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java +++ b/runners/java-job-service/src/test/java/org/apache/beam/runners/jobsubmission/PortablePipelineJarCreatorTest.java @@ -122,7 +122,7 @@ public void testCopyResourcesFromJar_ignoresDuplicates() throws IOException { } private static class FakePipelineRunnner { - public static void main(String[] args) { + public static void main(@SuppressWarnings("unused") String[] args) { System.out.println("Hello world"); } } @@ -145,7 +145,7 @@ public void testCreateManifest_withoutMainMethod() { @SuppressWarnings("IncorrectMainMethod") // intended private static class EvilPipelineRunner { - public static int main(String[] args) { + public static int main(@SuppressWarnings("unused") String[] args) { return 0; } } diff --git a/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java b/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java index 6b4d464b8e7c..7df0af71dc4c 100644 --- a/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java +++ b/runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java @@ -558,6 +558,6 @@ public void processElement(WindowedValue inputElement, OpEmitter< private static class NoOpDoFn extends DoFn { @ProcessElement - public void doNothing(ProcessContext context) {} + public void doNothing(@SuppressWarnings("unused") ProcessContext context) {} } } diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java index 86af822a6a4b..10a3ea64956b 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Select.java @@ -135,8 +135,7 @@ private static class SelectDoFn extends DoFn { @FieldAccess("selectFields") final FieldAccessDescriptor fieldAccess = FieldAccessDescriptor.withAllFields(); - public SelectDoFn( - FieldAccessDescriptor fieldAccessDescriptor, Schema inputSchema, Schema outputSchema) { + public SelectDoFn(FieldAccessDescriptor fieldAccessDescriptor, Schema inputSchema) { this.rowSelector = new RowSelectorContainer(inputSchema, fieldAccessDescriptor, true); } @@ -204,7 +203,7 @@ public PCollection expand(PCollection input) { + input.getSchema()); } return input - .apply(ParDo.of(new SelectDoFn<>(resolved, inputSchema, outputSchema))) + .apply(ParDo.of(new SelectDoFn<>(resolved, inputSchema))) .setRowSchema(outputSchema); } } @@ -316,7 +315,7 @@ public PCollection expand(PCollection input) { outputSchema = inferredOutputSchema; } return input - .apply(ParDo.of(new SelectDoFn<>(fieldAccessDescriptor, inputSchema, outputSchema))) + .apply(ParDo.of(new SelectDoFn<>(fieldAccessDescriptor, inputSchema))) .setRowSchema(outputSchema); } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java index 36966c2d35d6..bcc102edb7ff 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderRegistryTest.java @@ -282,7 +282,7 @@ private static class PTransformOutputingMySerializableGeneric private static class OutputDoFn extends DoFn>> { @ProcessElement - public void processElement(ProcessContext c) {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) {} } @Override @@ -339,7 +339,7 @@ private static class GenericOutputMySerializedGeneric private class OutputDoFn extends DoFn>> { @ProcessElement - public void processElement(ProcessContext c) {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) {} } @Override diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java index 5a112d5084dd..a7b8781c310a 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java @@ -1957,7 +1957,8 @@ private String emptyStringErrorMessage(String type) { } private static class RegisteredTestRunner extends PipelineRunner { - public static PipelineRunner fromOptions(PipelineOptions options) { + public static PipelineRunner fromOptions( + @SuppressWarnings("unused") PipelineOptions options) { return new RegisteredTestRunner(); } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java index 780ca9adc270..6a4f49db0ae5 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java @@ -1247,6 +1247,7 @@ public void testDisplayDataExcludesJsonIgnoreOptions() { } private static class CapturesOptions implements Serializable { + @SuppressWarnings("unused") PipelineOptions options = PipelineOptionsFactory.create(); } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java index b67b72073e91..b3ecf0ab5b30 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/JsonUtilsTest.java @@ -94,7 +94,9 @@ private static TestCase testCase(T cat) { private static class TestCase { + @SuppressWarnings("unused") final String name; + final T userT; final String jsonString; final byte[] jsonBytes; diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java index f27b936b7110..cab3dac5ee21 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DoFnTesterTest.java @@ -375,7 +375,7 @@ public void startBundle() { } @ProcessElement - public void processElement(ProcessContext c) { + public void processElement(@SuppressWarnings("unused") ProcessContext c) { elements++; } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java index 05739c0f451d..4c1c692765fa 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/WaitTest.java @@ -462,7 +462,7 @@ public void process(ProcessContext c) { ParDo.of( new DoFn() { @ProcessElement - public void process(ProcessContext c, BoundedWindow w) { + public void process(ProcessContext c, @SuppressWarnings("unused") BoundedWindow w) { while (true) { Instant maxMainTimestamp = TEST_WAIT_MAX_MAIN_TIMESTAMP.get(); Instant newMaxTimestamp = diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java index c80e92a897f9..65372573fcd3 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/display/DisplayDataTest.java @@ -1217,7 +1217,7 @@ public void testCanSerializeItemSpecReference() { } private static class HoldsItemSpecReference implements Serializable { - public HoldsItemSpecReference(DisplayData.ItemSpec spec) {} + public HoldsItemSpecReference(@SuppressWarnings("unused") DisplayData.ItemSpec spec) {} } @Test diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java index f31899d118b7..5921d6ee9c3e 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DefaultPackageTest.java @@ -47,6 +47,6 @@ public void defaultPackageInvoker() { private static class MyFn extends DoFn { @ProcessElement - public void processElement(ProcessContext context) {} + public void processElement(@SuppressWarnings("unused") ProcessContext context) {} } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java index 5a22203a8a76..8fabcc40956c 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesSplittableDoFnTest.java @@ -193,10 +193,12 @@ class UnboundedSplittableFn extends BaseSplittableFn {} private static class BaseFnWithoutContinuation extends DoFn { @ProcessElement public void processElement( - ProcessContext context, RestrictionTracker tracker) {} + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") RestrictionTracker tracker) {} @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer element) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer element) { return null; } } @@ -204,12 +206,14 @@ public SomeRestriction getInitialRestriction(@Element Integer element) { private static class BaseFnWithContinuation extends DoFn { @ProcessElement public ProcessContinuation processElement( - ProcessContext context, RestrictionTracker tracker) { + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") RestrictionTracker tracker) { return null; } @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer element) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer element) { return null; } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java index 019f68347935..19f081bdd831 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformReplacementsTest.java @@ -129,6 +129,6 @@ public void getMainInputNoMainInputsThrows() { private static class TestDoFn extends DoFn { @ProcessElement - public void process(ProcessContext context) {} + public void process(@SuppressWarnings("unused") ProcessContext context) {} } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java index e0ca074f822c..30be422b2ee6 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PTransformTranslationTest.java @@ -159,7 +159,7 @@ private RunnerApi.PTransform convert(ToAndFromProtoSpec spec, SdkComponents comp private static class TestDoFn extends DoFn> { // Exists to stop the ParDo application from throwing @ProcessElement - public void process(ProcessContext context) {} + public void process(@SuppressWarnings("unused") ProcessContext context) {} } private static AppliedPTransform generateSequence(Pipeline pipeline) { diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java index 6ef836038196..47b00a75e1d4 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/ParDoTranslationTest.java @@ -280,7 +280,9 @@ public void testStateSpecToFromProto() throws Exception { private static class DropElementsFn extends DoFn, Void> { @ProcessElement - public void proc(ProcessContext context, BoundedWindow window) { + public void proc( + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") BoundedWindow window) { context.output(null); } @@ -297,17 +299,20 @@ public int hashCode() { private static class SplittableDropElementsFn extends DoFn, Void> { @ProcessElement - public void proc(ProcessContext context, RestrictionTracker restriction) { + public void proc( + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") RestrictionTracker restriction) { context.output(null); } @GetInitialRestriction - public Integer restriction(@Element KV elem) { + public Integer restriction(@SuppressWarnings("unused") @Element KV elem) { return 42; } @NewTracker - public RestrictionTracker newTracker(@Restriction Integer restriction) { + public RestrictionTracker newTracker( + @SuppressWarnings("unused") @Restriction Integer restriction) { throw new UnsupportedOperationException("Should never be called; only to test translation"); } @@ -388,7 +393,7 @@ public int hashCode() { public static class BundleFinalizerTranslation { private static class StartBundleDoFn extends DoFn { @StartBundle - public void startBundle(BundleFinalizer bundleFinalizer) {} + public void startBundle(@SuppressWarnings("unused") BundleFinalizer bundleFinalizer) {} @ProcessElement public void processElement() {} @@ -396,15 +401,15 @@ public void processElement() {} private static class ProcessContextDoFn extends DoFn { @ProcessElement - public void processElement(BundleFinalizer finalizer) {} + public void processElement(@SuppressWarnings("unused") BundleFinalizer finalizer) {} } private static class FinishBundleDoFn extends DoFn { @FinishBundle - public void finishBundle(BundleFinalizer bundleFinalizer) {} + public void finishBundle(@SuppressWarnings("unused") BundleFinalizer bundleFinalizer) {} @ProcessElement - public void processElement(BundleFinalizer finalizer) {} + public void processElement(@SuppressWarnings("unused") BundleFinalizer finalizer) {} } @Test diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java index e3521f257d44..d90efae4fb3d 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/PipelineTranslationTest.java @@ -275,7 +275,7 @@ private static Optional getCombinePayload( private static class DoFnRequiringStableInput extends DoFn { @RequiresStableInput @ProcessElement - public void process(ProcessContext c) { + public void process(@SuppressWarnings("unused") ProcessContext c) { // actually never executed and no effect on translation } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java index 470d30710242..c6e0ebfecaf0 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/SplittableParDoTest.java @@ -106,10 +106,12 @@ public IsBounded isBounded() { private static class BoundedFakeFn extends DoFn { @ProcessElement public void processElement( - ProcessContext context, RestrictionTracker tracker) {} + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") RestrictionTracker tracker) {} @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer element) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer element) { return null; } } @@ -117,12 +119,14 @@ public SomeRestriction getInitialRestriction(@Element Integer element) { private static class UnboundedFakeFn extends DoFn { @ProcessElement public ProcessContinuation processElement( - ProcessContext context, RestrictionTracker tracker) { + @SuppressWarnings("unused") ProcessContext context, + @SuppressWarnings("unused") RestrictionTracker tracker) { return stop(); } @GetInitialRestriction - public SomeRestriction getInitialRestriction(@Element Integer element) { + public SomeRestriction getInitialRestriction( + @SuppressWarnings("unused") @Element Integer element) { return null; } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java index d43d59a88396..484fea20e24d 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/FieldAccessVisitorTest.java @@ -171,7 +171,8 @@ public PCollection expand(PCollection input) { @ProcessElement public void processElement( - @FieldAccess("row") Row row, OutputReceiver outputReceiver) + @SuppressWarnings("unused") @FieldAccess("row") Row row, + @SuppressWarnings("unused") OutputReceiver outputReceiver) throws Exception { // Do nothing; we don't need to execute this DoFn. } @@ -183,7 +184,7 @@ public void processElement( /** Just some random DoFn without field access information. */ private static class UnknownDoFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) { + public void processElement(@SuppressWarnings("unused") ProcessContext c) { // Do nothing; we don't need to execute this DoFn. } } @@ -191,7 +192,7 @@ public void processElement(ProcessContext c) { /** Just some random DoFn that process raw strings, no Rows or Schemas involved. */ private static class StringDoFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) { + public void processElement(@SuppressWarnings("unused") ProcessContext c) { // Do nothing; we don't need to execute this DoFn. } } diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java index 4644e2458dc4..0bed65f4f42b 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionProducerVisitorTest.java @@ -240,7 +240,7 @@ public PCollection expand(PBegin input) { private static class NoOpDoFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) {} } private static class MultipleOutputSourceWithPushdown extends PTransform diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java index 9707062c4f2c..51241247a395 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/ProjectionPushdownOptimizerTest.java @@ -185,7 +185,8 @@ public PCollection expand(PCollection input) { @ProcessElement public void processElement( - @FieldAccess("row") Row row, OutputReceiver outputReceiver) + @SuppressWarnings("unused") @FieldAccess("row") Row row, + @SuppressWarnings("unused") OutputReceiver outputReceiver) throws Exception { // Do nothing; we don't need to execute this DoFn. } @@ -293,7 +294,7 @@ public PTransform, PCollection> actuateProjectionPushdown( private static class NoOpDoFn extends DoFn { @ProcessElement - public void processElement(ProcessContext c) {} + public void processElement(@SuppressWarnings("unused") ProcessContext c) {} } private static class MultipleOutputSourceWithPushdown extends PTransform diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java index 9ff664887590..a378cbbf31b9 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/construction/graph/QueryablePipelineTest.java @@ -370,7 +370,7 @@ public void getEnvironmentWithEnvironment() { private static class TestFn extends DoFn { @ProcessElement - public void process(ProcessContext ctxt) {} + public void process(@SuppressWarnings("unused") ProcessContext ctxt) {} } @Test diff --git a/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java b/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java index c3c3ccfd3266..21f581d29250 100644 --- a/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java +++ b/sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java @@ -892,7 +892,7 @@ private static void printUsage() { } private static class NotRunnableRunner extends PipelineRunner { - public static NotRunnableRunner fromOptions(PipelineOptions opts) { + public static NotRunnableRunner fromOptions(@SuppressWarnings("unused") PipelineOptions opts) { return new NotRunnableRunner(); } diff --git a/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java b/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java index 2c0337979c05..24f2d6d82c9a 100644 --- a/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java +++ b/sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java @@ -921,6 +921,7 @@ private static class HasGenericRecord { @AvroSchema( "{\"name\": \"bar\", \"type\": \"record\", \"fields\": [" + "{\"name\": \"foo\", \"type\": \"int\"}]}") + @SuppressWarnings("unused") GenericRecord genericRecord; } @@ -938,6 +939,7 @@ private static class HasCustomSchema { @AvroSchema( "{\"name\": \"bar\", \"type\": \"record\", \"fields\": [" + "{\"name\": \"foo\", \"type\": \"int\"}]}") + @SuppressWarnings("unused") int withCustomSchema; } diff --git a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java index 2255a0ebcc86..d5684b4c2ae2 100644 --- a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java +++ b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/nfa/NFA.java @@ -650,7 +650,6 @@ private static class State implements Serializable { private final CEPOperation condition; // condition to evaluate when taking the "begin" action and "proceed" action private State nextState = null; - public final boolean isStart; public final boolean isFinal; private final boolean isKleenePlusSecondary; // whether is the second state for a Kleene Plus pattern variable @@ -659,13 +658,11 @@ private static class State implements Serializable { String patternVar, Quantifier quant, CEPOperation condition, - boolean isStart, boolean isFinal, boolean isKleenePlusSecondary) { this.patternVar = patternVar; this.quant = quant; this.condition = condition; - this.isStart = isStart; this.isFinal = isFinal; this.isKleenePlusSecondary = isKleenePlusSecondary; } @@ -764,16 +761,9 @@ private static State setNextStatesAndAssignIndices(List states) { // constructs states for the NFA and returns the start state private State loadStates(List patterns) { - boolean startState; ArrayList states = new ArrayList<>(); for (int i = 0; i < patterns.size(); ++i) { - if (i == 0) { - startState = true; - } else { - startState = false; - } - CEPPattern currentPattern = patterns.get(i); CEPOperation condition = currentPattern.getPatternCondition(); Quantifier quantifier = currentPattern.getQuantifier(); @@ -782,35 +772,22 @@ private State loadStates(List patterns) { // for Kleene plus, we need a pair of states State primaryState = - new State( - currentPattern.getPatternVar(), - Quantifier.PLUS, - condition, - startState, - false, - false); + new State(currentPattern.getPatternVar(), Quantifier.PLUS, condition, false, false); State secondaryState = - new State( - currentPattern.getPatternVar(), - Quantifier.PLUS, - condition, - startState, - false, - true); + new State(currentPattern.getPatternVar(), Quantifier.PLUS, condition, false, true); primaryState.setNextState(secondaryState); states.add(primaryState); } else { // for non-Kleene-Plus pattern var, construct a single state State newState = - new State( - currentPattern.getPatternVar(), quantifier, condition, startState, false, false); + new State(currentPattern.getPatternVar(), quantifier, condition, false, false); states.add(newState); } } // add final state - State theFinalState = new State("", Quantifier.NONE, null, false, true, false); + State theFinalState = new State("", Quantifier.NONE, null, true, false); states.add(theFinalState); State beginState = setNextStatesAndAssignIndices(states); return beginState; diff --git a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java index c54ab14ba8d8..d5baf29fca22 100644 --- a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java +++ b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java @@ -407,7 +407,7 @@ private static class RowCounter extends DoFn { final Counter rows = Metrics.counter(BeamEnumerableConverter.class, "rows"); @ProcessElement - public void processElement(ProcessContext context) { + public void processElement(@SuppressWarnings("unused") ProcessContext context) { rows.inc(); } } diff --git a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java index b47ff66329df..e597b6c63ed4 100644 --- a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java +++ b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamWindowRel.java @@ -285,7 +285,9 @@ private static DoFn, Row> aggField( return new DoFn, Row>() { @ProcessElement public void processElement( - @Element List inputPartition, OutputReceiver out, ProcessContext c) { + @Element List inputPartition, + OutputReceiver out, + @SuppressWarnings("unused") ProcessContext c) { List sortedRowsAsList = inputPartition; NavigableMap> indexRange = null; if (!fieldAgg.rows) { @@ -406,7 +408,7 @@ static class SelectOnlyValues extends DoFn>, Iterable public void processElement( @Element KV> inputPartition, OutputReceiver> out, - ProcessContext c) { + @SuppressWarnings("unused") ProcessContext c) { out.output(inputPartition.getValue()); } } @@ -415,7 +417,9 @@ private static DoFn, List> sortPartition(final FieldAggregati return new DoFn, List>() { @ProcessElement public void processElement( - @Element Iterable inputPartition, OutputReceiver> out, ProcessContext c) { + @Element Iterable inputPartition, + OutputReceiver> out, + @SuppressWarnings("unused") ProcessContext c) { List partitionRows = Lists.newArrayList(inputPartition); BeamSortRel.BeamSqlRowComparator beamSqlRowComparator = new BeamSortRel.BeamSqlRowComparator( diff --git a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java index 99915b33bf8b..697643d4715c 100644 --- a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java +++ b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverterTest.java @@ -146,7 +146,7 @@ public POutput buildIOWriter(PCollection input) { ParDo.of( new DoFn() { @ProcessElement - public void processElement(ProcessContext context) {} + public void processElement(@SuppressWarnings("unused") ProcessContext context) {} })); return PDone.in(input.getPipeline()); } diff --git a/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java b/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java index fa8b6befabad..c52d38c73e6b 100644 --- a/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java +++ b/sdks/java/io/datadog/src/main/java/org/apache/beam/sdk/io/datadog/DatadogIO.java @@ -210,11 +210,9 @@ public PCollection> expand(PCollection i private static class CreateKeysFn extends DoFn> { - @Nullable private Integer specifiedParallelism; private Integer calculatedParallelism; CreateKeysFn(@Nullable Integer specifiedParallelism) { - this.specifiedParallelism = specifiedParallelism; this.calculatedParallelism = MoreObjects.firstNonNull(specifiedParallelism, DEFAULT_PARALLELISM); LOG.info("Parallelism set to: {}", calculatedParallelism); diff --git a/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java b/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java index ba4ac2769949..e273716013d7 100644 --- a/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java +++ b/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java @@ -2746,7 +2746,7 @@ public void setup() throws IOException { } @StartBundle - public void startBundle(StartBundleContext context) { + public void startBundle(@SuppressWarnings("unused") StartBundleContext context) { batch = new ArrayList<>(); currentBatchSizeBytes = 0; } diff --git a/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java b/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java index e4bc63cd8d8e..4138d00e6488 100644 --- a/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java +++ b/sdks/java/io/file-schema-transform/src/test/java/org/apache/beam/sdk/io/fileschematransform/JsonReadSchemaTransformFormatProviderTest.java @@ -200,11 +200,9 @@ public void runWriteAndReadTest( } private static class CreateKVJsonString extends SimpleFunction> { - Schema schema; PayloadSerializer payloadSerializer; - CreateKVJsonString(Schema schema, PayloadSerializer payloadSerializer) { - this.schema = schema; + CreateKVJsonString(PayloadSerializer payloadSerializer) { this.payloadSerializer = payloadSerializer; } @@ -248,7 +246,7 @@ public void testStreamingRead() { .withAllowedLateness(Duration.ZERO) .triggering(Repeatedly.forever(AfterPane.elementCountAtLeast(1))) .discardingFiredPanes()) - .apply(MapElements.via(new CreateKVJsonString(schema, payloadSerializer))) + .apply(MapElements.via(new CreateKVJsonString(payloadSerializer))) .setCoder(KvCoder.of(VarIntCoder.of(), StringUtf8Coder.of())) .apply( FileIO.>writeDynamic() @@ -280,7 +278,7 @@ public void testReadWithPCollectionOfFilepatterns() { // Write rows to dynamic destinations (test_1.., test_2.., test_3..) writePipeline .apply(Create.of(Arrays.asList(0L, 1L, 2L))) - .apply(MapElements.via(new CreateKVJsonString(schema, payloadSerializer))) + .apply(MapElements.via(new CreateKVJsonString(payloadSerializer))) .setCoder(KvCoder.of(VarIntCoder.of(), StringUtf8Coder.of())) .apply( FileIO.>writeDynamic() diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java index 65bb3bf11b1b..b9cd554b578b 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java @@ -80,15 +80,10 @@ public class UpdateSchemaDestination private static class PendingJobData { final BigQueryHelpers.PendingJob retryJob; final TableDestination tableDestination; - final BoundedWindow window; - public PendingJobData( - BigQueryHelpers.PendingJob retryJob, - TableDestination tableDestination, - BoundedWindow window) { + public PendingJobData(BigQueryHelpers.PendingJob retryJob, TableDestination tableDestination) { this.retryJob = retryJob; this.tableDestination = tableDestination; - this.window = window; } } @@ -145,7 +140,7 @@ TableDestination getTableWithDefaultProject(DestinationT destination) { public void processElement( @Element Iterable> element, ProcessContext context, - BoundedWindow window) + @SuppressWarnings("unused") BoundedWindow window) throws IOException { dynamicDestinations.setSideInputAccessorFromProcessContext(context); List> outputs = Lists.newArrayList(); @@ -179,7 +174,7 @@ public void processElement( schemaUpdateOptions); if (updateSchemaDestinationJob != null) { pendingJobs.put( - destination, new PendingJobData(updateSchemaDestinationJob, tableDestination, window)); + destination, new PendingJobData(updateSchemaDestinationJob, tableDestination)); } } if (!pendingJobs.isEmpty()) { diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java index 288b94ce081b..fd0df20b496c 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java @@ -178,7 +178,7 @@ public PendingJobData( private List pendingJobs = Lists.newArrayList(); @StartBundle - public void startBundle(StartBundleContext c) { + public void startBundle(@SuppressWarnings("unused") StartBundleContext c) { // Clear the map on each bundle so we can notice side-input updates. // (alternative is to use a cache with a TTL). jsonSchemas.clear(); diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java index f9f86cc80186..e3d947235015 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java @@ -155,7 +155,7 @@ public void process(ProcessContext c) { } @FinishBundle - public void finish(FinishBundleContext c) { + public void finish(@SuppressWarnings("unused") FinishBundleContext c) { this.bqGenericElementCounter.inc(this.elementsInBundle); this.elementsInBundle = 0L; } @@ -170,7 +170,7 @@ public void process(ProcessContext c) { private static class NoOutputDoFn extends DoFn { @ProcessElement - public void process(ProcessContext c) {} + public void process(@SuppressWarnings("unused") ProcessContext c) {} } @Override diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java index 8a628817fe27..c690115045bd 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubReadSchemaTransformProvider.java @@ -233,7 +233,7 @@ public void process(@DoFn.Element PubsubMessage message, MultiOutputReceiver rec } @FinishBundle - public void finish(FinishBundleContext c) { + public void finish(@SuppressWarnings("unused") FinishBundleContext c) { pubsubErrorCounter.inc(errorsInBundle); errorsInBundle = 0L; } diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java index 3a69d1177f4a..fc1d93965e4a 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java @@ -1958,11 +1958,6 @@ && getInclusiveStartAt().toSqlTimestamp().after(getInclusiveEndAt().toSqlTimesta getMetadataInstance(), changeStreamDatabaseId.getInstanceId().getInstance()); final String partitionMetadataDatabaseId = MoreObjects.firstNonNull(getMetadataDatabase(), changeStreamDatabaseId.getDatabase()); - final DatabaseId fullPartitionMetadataDatabaseId = - DatabaseId.of( - getSpannerConfig().getProjectId().get(), - partitionMetadataInstanceId, - partitionMetadataDatabaseId); final SpannerConfig changeStreamSpannerConfig = buildChangeStreamSpannerConfig(); final SpannerConfig partitionMetadataSpannerConfig = diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java index 61955f448c3f..eee13b0a932f 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java @@ -132,7 +132,7 @@ public void process(ProcessContext c) { } @FinishBundle - public void finish(FinishBundleContext c) { + public void finish(@SuppressWarnings("unused") FinishBundleContext c) { this.spannerGenericElementCounter.inc(this.elementsInBundle); this.elementsInBundle = 0L; } @@ -140,7 +140,7 @@ public void finish(FinishBundleContext c) { private static class NoOutputDoFn extends DoFn { @ProcessElement - public void process(ProcessContext c) {} + public void process(@SuppressWarnings("unused") ProcessContext c) {} } @Override diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java index 95f472f5c61b..db5777627a39 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java @@ -2675,7 +2675,10 @@ private ReadRowsResponse createArrowTsResponse( } private ReadRowsResponse createAvroTsResponse( - Schema avroSchema, TimestampPrecision precision, List inputValues) throws Exception { + Schema avroSchema, + @SuppressWarnings("unused") TimestampPrecision precision, + List inputValues) + throws Exception { List records = new ArrayList<>(); for (Object value : inputValues) { GenericRecord record = new Record(avroSchema); diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java index d3408536c82a..cd4715b063f3 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamResultSetTest.java @@ -34,7 +34,6 @@ public class ChangeStreamResultSetTest { @Test public void testGetBytes() throws Exception { // 1. Create an expected ChangeStreamRecord proto - Timestamp now = Timestamp.now(); final HeartbeatRecord heartbeatRecord = new HeartbeatRecord(Timestamp.ofTimeSecondsAndNanos(10L, 20), null); com.google.spanner.v1.ChangeStreamRecord expectedRecord = recordToProto(heartbeatRecord); diff --git a/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java b/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java index 6ca2fe1aa3be..d32cf677d824 100644 --- a/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java +++ b/sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java @@ -745,7 +745,7 @@ public void setup() throws Exception { } @StartBundle - public void startBundle(StartBundleContext c) throws IOException { + public void startBundle(@SuppressWarnings("unused") StartBundleContext c) throws IOException { BufferedMutatorParams params = new BufferedMutatorParams(TableName.valueOf(tableId)); mutator = connection.getBufferedMutator(params); recordsWritten = 0; @@ -913,7 +913,7 @@ public void setup() throws Exception { } @StartBundle - public void startBundle(StartBundleContext c) throws IOException { + public void startBundle(@SuppressWarnings("unused") StartBundleContext c) throws IOException { table = connection.getTable(TableName.valueOf(tableId)); recordsWritten = 0; } diff --git a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java index 8835e2ff628b..fbd6c15095e9 100644 --- a/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java +++ b/sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteDirectRowsToFiles.java @@ -98,7 +98,7 @@ public void startBundle() { @ProcessElement public void processElement( - ProcessContext context, + @SuppressWarnings("unused") ProcessContext context, @Element KV element, BoundedWindow window, PaneInfo paneInfo) diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java index 4dbb9b396f09..3386fbe090d0 100644 --- a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java +++ b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcWriteSchemaTransformProvider.java @@ -238,7 +238,7 @@ protected String writeStatement(Schema schema) { private static class NoOutputDoFn extends DoFn { @ProcessElement - public void process(ProcessContext c) {} + public void process(@SuppressWarnings("unused") ProcessContext c) {} } @Override diff --git a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java index 5f53d3243001..0f8088969aa9 100644 --- a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java +++ b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java @@ -308,7 +308,8 @@ private static class GenerateRecordsStream extends PTransform> rows = sdfReadPipeline.apply( "Read from bounded Kafka", diff --git a/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java b/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java index 6d6296733db3..795c0187b94b 100644 --- a/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java +++ b/sdks/java/io/kudu/src/main/java/org/apache/beam/sdk/io/kudu/KuduIO.java @@ -430,12 +430,14 @@ public void setup() throws KuduException { } @StartBundle - public void startBundle(StartBundleContext context) throws KuduException { + public void startBundle(@SuppressWarnings("unused") StartBundleContext context) + throws KuduException { writer.openSession(); } @ProcessElement - public void processElement(ProcessContext c) throws KuduException { + public void processElement(@SuppressWarnings("unused") ProcessContext c) + throws KuduException { writer.write(c.element()); } diff --git a/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java b/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java index 8c4a3af282e1..6f401161a12f 100644 --- a/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java +++ b/sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIOUtils.java @@ -21,12 +21,9 @@ import org.apache.pulsar.client.admin.PulsarAdmin; import org.apache.pulsar.client.api.PulsarClient; import org.apache.pulsar.client.api.PulsarClientException; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; final class PulsarIOUtils { - private static final Logger LOG = LoggerFactory.getLogger(PulsarIOUtils.class); static final String LOCAL_SERVICE_URL = "pulsar://localhost:6650"; static final long DEFAULT_CONSUMER_POLLING_TIMEOUT = 2L; diff --git a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java index 52ee3044d60c..37f48672b739 100644 --- a/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java +++ b/sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOTest.java @@ -32,15 +32,12 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; // TODO(https://github.com/apache/beam/issues/31078) exceptions are currently suppressed @SuppressWarnings("Slf4jDoNotLogMessageOfExceptionExplicitly") @RunWith(JUnit4.class) public class PulsarIOTest implements Serializable { @Rule public final transient TestPipeline pipeline = TestPipeline.create(); - private static final Logger LOG = LoggerFactory.getLogger(PulsarIOTest.class); private static final String TEST_TOPIC = "TEST_TOPIC"; // In order to pin fake readers having same set of messages diff --git a/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java b/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java index b8057d879686..00a25064b9f3 100644 --- a/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java +++ b/sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreIO.java @@ -734,13 +734,14 @@ public void processElement( } @GetInitialRestriction - public OffsetRange getInitialRange(@Element ParameterT element) throws Exception { + public OffsetRange getInitialRange(@SuppressWarnings("unused") @Element ParameterT element) + throws Exception { return new OffsetRange(0L, getNumPartitions()); } @SplitRestriction public void splitRange( - @Element ParameterT element, + @SuppressWarnings("unused") @Element ParameterT element, @Restriction OffsetRange range, OutputReceiver receiver) { for (long i = range.getFrom(); i < range.getTo(); i++) { diff --git a/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java b/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java index 4183906e769b..eef47dddfcdd 100644 --- a/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java +++ b/sdks/java/ml/inference/remote/src/test/java/org/apache/beam/sdk/ml/inference/remote/RemoteInferenceTest.java @@ -178,12 +178,10 @@ public static Builder builder() { public static class MockSuccessHandler implements BaseModelHandler { - private TestParameters parameters; private boolean clientCreated = false; @Override - public void createClient(TestParameters parameters) { - this.parameters = parameters; + public void createClient(@SuppressWarnings("unused") TestParameters parameters) { this.clientCreated = true; } @@ -203,7 +201,7 @@ public static class MockEmptyResultHandler implements BaseModelHandler { @Override - public void createClient(TestParameters parameters) { + public void createClient(@SuppressWarnings("unused") TestParameters parameters) { // Setup succeeds } @@ -218,7 +216,7 @@ public static class MockFailingSetupHandler implements BaseModelHandler { @Override - public void createClient(TestParameters parameters) { + public void createClient(@SuppressWarnings("unused") TestParameters parameters) { throw new RuntimeException("Setup failed intentionally"); } @@ -233,7 +231,7 @@ public static class MockFailingRequestHandler implements BaseModelHandler { @Override - public void createClient(TestParameters parameters) { + public void createClient(@SuppressWarnings("unused") TestParameters parameters) { // Setup succeeds } @@ -247,14 +245,10 @@ public Iterable> request(List public static class MockNoDefaultConstructorHandler implements BaseModelHandler { - private final String required; - - public MockNoDefaultConstructorHandler(String required) { - this.required = required; - } + public MockNoDefaultConstructorHandler(@SuppressWarnings("unused") String required) {} @Override - public void createClient(TestParameters parameters) {} + public void createClient(@SuppressWarnings("unused") TestParameters parameters) {} @Override public Iterable> request(List input) { diff --git a/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java b/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java index ef95dcd611bb..12c05ff47fd1 100644 --- a/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java +++ b/sdks/java/testing/junit/src/main/java/org/apache/beam/sdk/testing/TestPipelineExtension.java @@ -72,7 +72,6 @@ public class TestPipelineExtension private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace.create(TestPipelineExtension.class); private static final String PIPELINE_KEY = "testPipeline"; - private static final String ENFORCEMENT_KEY = "enforcement"; /** Creates a new TestPipelineExtension with default options. */ public static TestPipelineExtension create() { diff --git a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java index e2fef254d130..d01ae06f309c 100644 --- a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java +++ b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java @@ -121,7 +121,7 @@ private static class MonitorWithCounter extends DoFn { private final Counter elementCounter = Metrics.counter(NAMESPACE, "counter"); @ProcessElement - public void processElement(ProcessContext c) { + public void processElement(@SuppressWarnings("unused") ProcessContext c) { elementCounter.inc(); } }