diff --git a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy index fe0f1ab8bc91..2e4ed985a60d 100644 --- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy +++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy @@ -1549,9 +1549,9 @@ class BeamModulePlugin implements Plugin { "InvalidInlineTag", "InvalidLink", "InvalidParam", - "InvalidThrows", + "InvalidParam", + "JavaTimeDefaultTimeZone", "JavaTimeDefaultTimeZone", - "JavaUtilDate", "JodaConstructors", "MalformedInlineTag", "MixedMutabilityReturnType", @@ -1561,7 +1561,7 @@ class BeamModulePlugin implements Plugin { "Slf4jSignOnlyFormat", "StaticAssignmentInConstructor", "ThreadPriorityCheck", - "TimeUnitConversionChecker", + "ThreadPriorityCheck", "UndefinedEquals", "UnescapedEntity", "UnnecessaryLambda", diff --git a/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java b/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java index 9d908e8bd6ca..2b9adf0f2a24 100644 --- a/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java +++ b/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java @@ -132,7 +132,6 @@ public String getJsonBeamSchema() { * * @param filePath path to file in GCS * @return contents of the file as a string - * @throws IOException thrown if not able to read file */ public static String getGcsFileAsString(String filePath) { MatchResult result; diff --git a/examples/java/src/test/java/org/apache/beam/examples/WindowedWordCountIT.java b/examples/java/src/test/java/org/apache/beam/examples/WindowedWordCountIT.java index fa25d72cb22a..f7b858ccf5eb 100644 --- a/examples/java/src/test/java/org/apache/beam/examples/WindowedWordCountIT.java +++ b/examples/java/src/test/java/org/apache/beam/examples/WindowedWordCountIT.java @@ -20,9 +20,10 @@ import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.equalTo; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.ArrayList; import java.util.Collections; -import java.util.Date; import java.util.List; import java.util.SortedMap; import java.util.TreeMap; @@ -128,7 +129,9 @@ private WindowedWordCountITOptions defaultOptions() throws Exception { .resolve( String.format( "WindowedWordCountIT.%s-%tFT% queue2 = new LinkedBlockingQueue<>(); @Before + @SuppressWarnings("JavaUtilDate") public void setUp() throws JsonProcessingException { MockitoAnnotations.initMocks(this); when(status1.getText()).thenReturn("Breaking News1"); diff --git a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/DirectRunnerClient.java b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/DirectRunnerClient.java index aa44b4e55f3d..40de8b89695a 100644 --- a/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/DirectRunnerClient.java +++ b/it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/dataflow/DirectRunnerClient.java @@ -26,7 +26,6 @@ import java.lang.reflect.Method; import java.text.SimpleDateFormat; import java.util.ArrayList; -import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -74,7 +73,8 @@ public LaunchInfo launch(String project, String region, LaunchConfig options) th String jobId = "direct-" - + new SimpleDateFormat("yyyy-MM-dd_HH_mm_ss").format(new Date()) + + new SimpleDateFormat("yyyy-MM-dd_HH_mm_ss") + .format(java.time.Instant.now().toEpochMilli()) + "-" + System.currentTimeMillis(); diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java index 75478d52b335..f074d238cf00 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java @@ -17,7 +17,6 @@ */ package org.apache.beam.runners.core.metrics; -import java.util.Date; import java.util.Set; import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.locks.Lock; @@ -47,7 +46,8 @@ public String generateLogMessage( StringBuilder logMessage = new StringBuilder(); logMessage.append(header); logMessage.append(deltaContainer.getCumulativeString(allowedMetricUrns)); - logMessage.append(String.format("(last reported at %s)%n", new Date(lastReported))); + logMessage.append( + String.format("(last reported at %s)%n", java.time.Instant.ofEpochMilli(lastReported))); lastMetricsSnapshot = nextMetricsSnapshot; return logMessage.toString(); diff --git a/runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/FlinkRequiresStableInputTest.java b/runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/FlinkRequiresStableInputTest.java index b382cfeb6d22..4d7bb636038c 100644 --- a/runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/FlinkRequiresStableInputTest.java +++ b/runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/FlinkRequiresStableInputTest.java @@ -21,8 +21,9 @@ import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.equalTo; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.Collections; -import java.util.Date; import java.util.Optional; import java.util.concurrent.Executors; import org.apache.beam.model.jobmanagement.v1.JobApi; @@ -144,7 +145,9 @@ private void runTest(boolean portable) throws Exception { ResourceId outputDir = FileSystems.matchNewResource(tempFolder.getRoot().getAbsolutePath(), true) .resolve( - String.format("requires-stable-input-%tF-% urnsToOverride, PipelineOptions options) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/RequiresStableInputIT.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/RequiresStableInputIT.java index 1b809c5d170a..fee955956a5d 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/RequiresStableInputIT.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/RequiresStableInputIT.java @@ -24,7 +24,8 @@ import java.nio.ByteBuffer; import java.nio.channels.WritableByteChannel; import java.nio.charset.StandardCharsets; -import java.util.Date; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.UUID; import org.apache.beam.sdk.io.FileSystems; import org.apache.beam.sdk.io.fs.MatchResult; @@ -125,7 +126,9 @@ public void testParDoRequiresStableInput() { ResourceId outputDir = FileSystems.matchNewResource(options.getTempRoot(), true) .resolve( - String.format("requires-stable-input-%tF-%>> runQueryInBackground(String[] args) { }); } + @SuppressWarnings("JavaUtilDate") private long convertTimestampToMillis(String timestamp) throws ParseException { return dateFormat.parse(timestamp).getTime(); } diff --git a/sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/BigQueryHllSketchCompatibilityIT.java b/sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/BigQueryHllSketchCompatibilityIT.java index 2bd18ce32244..5fe1ed278ee4 100644 --- a/sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/BigQueryHllSketchCompatibilityIT.java +++ b/sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/BigQueryHllSketchCompatibilityIT.java @@ -28,9 +28,10 @@ import com.google.api.services.bigquery.model.TableSchema; import com.google.cloud.bigquery.storage.v1.DataFormat; import java.nio.ByteBuffer; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.Arrays; import java.util.Collections; -import java.util.Date; import java.util.List; import java.util.Map; import java.util.stream.Collectors; @@ -102,7 +103,9 @@ public class BigQueryHllSketchCompatibilityIT { TestPipeline.testingPipelineOptions().as(ApplicationNameOptions.class); APP_NAME = options.getAppName(); PROJECT_ID = options.as(GcpOptions.class).getProject(); - DATASET_ID = String.format("zetasketch_%tY_% toChangeStreamRecords( PartitionMetadata partition, diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java index 1da38e6d083e..6760d5e8e608 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadIT.java @@ -29,7 +29,8 @@ import com.google.cloud.bigtable.data.v2.models.RowMutation; import com.google.cloud.bigtable.data.v2.models.TableId; import java.io.IOException; -import java.util.Date; +import java.time.LocalDateTime; +import java.time.ZoneId; import org.apache.beam.repackaged.core.org.apache.commons.lang3.StringUtils; import org.apache.beam.sdk.Pipeline; import org.apache.beam.sdk.PipelineResult; @@ -55,7 +56,8 @@ public class BigtableReadIT { private String project; private BigtableTestOptions options; - private String tableId = String.format("BigtableReadIT-%tF-% writeTransform; diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java index 46bb3df836e5..32b747f01a72 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableWriteIT.java @@ -33,8 +33,9 @@ import com.google.cloud.bigtable.data.v2.models.Row; import com.google.protobuf.ByteString; import java.io.Serializable; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.ArrayList; -import java.util.Date; import java.util.Iterator; import java.util.List; import java.util.Objects; @@ -78,7 +79,7 @@ public class BigtableWriteIT implements Serializable { private static BigtableDataClient client; private static BigtableTableAdminClient tableAdminClient; private final String tableId = - String.format("BigtableWriteIT-%tF-% writeTransform; diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java index cf3d11e78489..a3c8f195bea5 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java @@ -1281,6 +1281,7 @@ private static RunQueryResponse makeStatKindResponse(long entitySizeInBytes) { } /** Builds a response of the given timestamp. */ + @SuppressWarnings("JavaUtilDate") private static RunQueryResponse makeLatestTimestampResponse(long timestamp) { RunQueryResponse.Builder timestampResponse = RunQueryResponse.newBuilder(); Entity.Builder entity = Entity.newBuilder(); diff --git a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsKmsKeyIT.java b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsKmsKeyIT.java index 67cf729c417f..f89e9ea619ec 100644 --- a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsKmsKeyIT.java +++ b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsKmsKeyIT.java @@ -23,8 +23,9 @@ import static org.junit.Assert.assertNotNull; import java.io.IOException; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.Collections; -import java.util.Date; import org.apache.beam.sdk.Pipeline; import org.apache.beam.sdk.PipelineResult; import org.apache.beam.sdk.PipelineResult.State; @@ -77,7 +78,9 @@ public void testGcsWriteWithKmsKey() { ResourceId filenamePrefix = FileSystems.matchNewResource(gcsOptions.getGcpTempLocation(), true) .resolve( - String.format("GcsKmsKeyIT-%tF-% fields) { .build()); /** PreparedStatementSetCaller for Schema Field Logical types. * */ + @SuppressWarnings("JavaUtilDate") static JdbcIO.PreparedStatementSetCaller getPreparedStatementSetCaller( Schema.FieldType fieldType) { switch (fieldType.getTypeName()) { diff --git a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java index 383b787e726d..9099583fb3d6 100644 --- a/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java +++ b/sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java @@ -1114,6 +1114,7 @@ public void testGetPreparedStatementSetNullsCaller() throws Exception { } @Test + @SuppressWarnings("JavaUtilDate") public void testGetPreparedStatementSetCallerForLogicalTypes() throws Exception { FieldType fixedLengthStringType = LogicalTypes.fixedLengthString(JDBCType.VARCHAR, 4); Schema schema = @@ -1171,7 +1172,7 @@ public void testGetPreparedStatementSetCallerForLogicalTypes() throws Exception Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("UTC")); cal.setTimeInMillis(epochMilli); - verify(psMocked, times(1)).setTimestamp(3, new Timestamp(cal.getTime().getTime()), cal); + verify(psMocked, times(1)).setTimestamp(3, new Timestamp(cal.getTimeInMillis()), cal); verify(psMocked, times(1)).setString(4, row.getString(3)); verify(psMocked, times(1)).setString(5, row.getString(4)); verify(psMocked, times(1)).setObject(6, row.getLogicalTypeValue(5, UUID.class)); diff --git a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java index 71f8b291e0d5..05468a28863b 100644 --- a/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java +++ b/sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java @@ -141,7 +141,7 @@ void parse( */ private static final Parser TEXT_PARSER = (gridFSFile, downloadStream, callback) -> { - final Instant time = new Instant(gridFSFile.getUploadDate().getTime()); + final Instant time = new Instant(gridFSFile.getUploadDate().toInstant().toEpochMilli()); try (BufferedReader reader = new BufferedReader(new InputStreamReader(downloadStream, StandardCharsets.UTF_8))) { for (String line = reader.readLine(); line != null; line = reader.readLine()) { diff --git a/sdks/java/io/mongodb/src/test/java/org/apache/beam/sdk/io/mongodb/MongoDBIOIT.java b/sdks/java/io/mongodb/src/test/java/org/apache/beam/sdk/io/mongodb/MongoDBIOIT.java index 73b9463e620a..67e9ce053f9e 100644 --- a/sdks/java/io/mongodb/src/test/java/org/apache/beam/sdk/io/mongodb/MongoDBIOIT.java +++ b/sdks/java/io/mongodb/src/test/java/org/apache/beam/sdk/io/mongodb/MongoDBIOIT.java @@ -24,7 +24,6 @@ import com.mongodb.client.MongoClient; import com.mongodb.client.MongoClients; import java.time.Instant; -import java.util.Date; import java.util.HashSet; import java.util.Map; import java.util.Set; @@ -141,7 +140,7 @@ public interface MongoDBPipelineOptions extends IOTestPipelineOptions { public static void setUp() { PipelineOptionsFactory.register(MongoDBPipelineOptions.class); options = TestPipeline.testingPipelineOptions().as(MongoDBPipelineOptions.class); - collection = String.format("test_%s", new Date().getTime()); + collection = String.format("test_%s", java.time.Instant.now().toEpochMilli()); if (StringUtils.isEmpty(options.getMongoDBUsername())) { mongoUrl = String.format("mongodb://%s:%s", options.getMongoDBHostName(), options.getMongoDBPort()); diff --git a/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqMessage.java b/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqMessage.java index bda291d52153..9936d9a9c6f8 100644 --- a/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqMessage.java +++ b/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqMessage.java @@ -132,6 +132,7 @@ private static Object getTransformedValue(Object value) { private final @Nullable String appId; private final @Nullable String clusterId; + @SuppressWarnings("JavaUtilDate") public RabbitMqMessage(byte[] body) { this.body = body; routingKey = ""; @@ -151,6 +152,7 @@ public RabbitMqMessage(byte[] body) { clusterId = null; } + @SuppressWarnings("JavaUtilDate") public RabbitMqMessage(String routingKey, GetResponse delivery) { this.routingKey = routingKey; delivery = serializableDeliveryOf(delivery); @@ -171,6 +173,7 @@ public RabbitMqMessage(String routingKey, GetResponse delivery) { clusterId = delivery.getProps().getClusterId(); } + @SuppressWarnings("JavaUtilDate") public RabbitMqMessage( String routingKey, byte[] body, diff --git a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java index 5350e0e2c1fe..51915ca0b79c 100644 --- a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java +++ b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java @@ -27,9 +27,9 @@ import java.io.Serializable; import java.security.PrivateKey; import java.sql.SQLException; -import java.text.SimpleDateFormat; +import java.time.LocalDateTime; +import java.time.ZoneId; import java.util.ArrayList; -import java.util.Date; import java.util.List; import java.util.UUID; import java.util.concurrent.ConcurrentHashMap; @@ -476,7 +476,8 @@ private void checkArguments() { private String makeTmpDirName() { return String.format( "sf_copy_csv_%s_%s", - new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date()), + LocalDateTime.now(ZoneId.of("UTC")) + .format(java.time.format.DateTimeFormatter.ofPattern("yyyyMMdd_HHmmss")), UUID.randomUUID().toString().subSequence(0, 8) // first 8 chars of UUID should be enough ); } diff --git a/sdks/java/testing/jpms-tests/src/test/java/org/apache/beam/sdk/jpmstests/JpmsIT.java b/sdks/java/testing/jpms-tests/src/test/java/org/apache/beam/sdk/jpmstests/JpmsIT.java index fe9e299b9c30..f9a8c945b0ca 100644 --- a/sdks/java/testing/jpms-tests/src/test/java/org/apache/beam/sdk/jpmstests/JpmsIT.java +++ b/sdks/java/testing/jpms-tests/src/test/java/org/apache/beam/sdk/jpmstests/JpmsIT.java @@ -20,7 +20,8 @@ import static org.apache.beam.sdk.testing.FileChecksumMatcher.fileContentsHaveChecksum; import static org.hamcrest.MatcherAssert.assertThat; -import java.util.Date; +import java.time.LocalDateTime; +import java.time.ZoneId; import org.apache.beam.sdk.io.FileSystems; import org.apache.beam.sdk.io.fs.ResolveOptions.StandardResolveOptions; import org.apache.beam.sdk.jpmstests.WordCount.WordCountOptions; @@ -55,7 +56,8 @@ public void testE2EJpms() { options.setOutput( FileSystems.matchNewResource(options.getTempRoot(), true) .resolve( - String.format("JpmsIT-%tF-% completion, int numOfResults) throws Exception { List> summaryRowsList = new ArrayList<>(); diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java index a8f479557005..da317d3ddceb 100644 --- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java +++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java @@ -247,6 +247,7 @@ private static List collectTpcdsResults( * @param results Tpcds run results * @throws Exception */ + @SuppressWarnings("JavaUtilDate") private static void printExecutionSummary(List results) throws Exception { List> summaryRowsList = new ArrayList<>(); for (TpcdsRunResult tpcdsRunResult : results) { diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java index 09f6376344ff..60072ea916c0 100644 --- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java +++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java @@ -62,7 +62,6 @@ public static String getAndCheckDataSize(TpcdsOptions tpcdsOptions) throws Excep * @param tpcdsOptions TpcdsOptions object constructed from user input * @return An array of query names, for example "1,2,14b" will be output as * "query1,query2,query14b" - * @throws Exception */ public static String[] getAndCheckQueryNames(TpcdsOptions tpcdsOptions) { if (tpcdsOptions.getQueries().equalsIgnoreCase("all")) { @@ -109,7 +108,6 @@ private static List getAllQueryNames() { * * @param tpcdsOptions TpcdsOptions object constructed from user input. * @return The TpcParallel user entered. - * @throws Exception */ public static int getAndCheckTpcParallel(TpcdsOptions tpcdsOptions) throws Exception { int nThreads = tpcdsOptions.getTpcParallel(); diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java index 2d29bb6dacc1..df2101c73641 100644 --- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java +++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java @@ -48,11 +48,13 @@ public boolean getIsSuccessful() { return isSuccessful; } + @SuppressWarnings("JavaUtilDate") public Date getStartDate() { Timestamp startTimeStamp = new Timestamp(startTime); return new Date(startTimeStamp.getTime()); } + @SuppressWarnings("JavaUtilDate") public Date getEndDate() { Timestamp endTimeStamp = new Timestamp(endTime); return new Date(endTimeStamp.getTime());