Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Recurrent golang stacktrace logs #4754

Closed
gansheer opened this issue Sep 15, 2023 · 2 comments · Fixed by #4757
Closed

E2E - Recurrent golang stacktrace logs #4754

gansheer opened this issue Sep 15, 2023 · 2 comments · Fixed by #4757
Labels
kind/bug Something isn't working

Comments

@gansheer
Copy link
Contributor

gansheer commented Sep 15, 2023

What happened?

While looking at some github action tests logs I noticed a few golang stacktraces that do not impact the completion/result of the tests but produce a lot of noise in the logs.

One of the only relevant reference I could find was this issue: solo-io/gloo#8548. It could be a result of zap upgrade.

Steps to reproduce

Look into an github action raw logs (common) -- preferably on passing tests.

Relevant log output

The trace is:

2023-09-15T13:52:02.6249978Z [controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:
2023-09-15T13:52:02.6250380Z goroutine 42 [running]:
2023-09-15T13:52:02.6250665Z runtime/debug.Stack()
2023-09-15T13:52:02.6251487Z 	/opt/hostedtoolcache/go/1.20.8/x64/src/runtime/debug/stack.go:24 +0x65
2023-09-15T13:52:02.6252078Z sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
2023-09-15T13:52:02.6252726Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.2/pkg/log/log.go:59 +0xbd
...

Camel K version

main branch

@gansheer gansheer added the kind/bug Something isn't working label Sep 15, 2023
@gansheer gansheer changed the title Recurrent golang stacktrace logs E2E - Recurrent golang stacktrace logs Sep 15, 2023
@squakez
Copy link
Contributor

squakez commented Sep 18, 2023

I think I saw this in some code refactoring for #4693 as well. The codegen client was failing and I fixed it in dea0159#diff-86796b17887d2911710b145814e1a09d041afe84f364546f71daf3d4c12972b9 - not sure if we need to adopt the same strategy though.

@gansheer
Copy link
Contributor Author

I'll try to add this change to the test init then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants