Configured backup time not reflected accurately in UI

[prashanthr2]

problem

Time field in Scheduled backups is confusing or is not being presented in the right way.

Below are the screenshots of some the Backup Schedule I created, and the Time seen in the Scheduled backups.

1. Schedule created for Daily backups to run as 12 PM. Time in the scheduled backup is seen as 00:12:00

2. Here is how the time field looks for the weekly backup schedule created to run at 4 AM every Saturday

versions

4.20
4.22 RC2

The steps to reproduce the bug

1 Enable backup.framework.enabled global setting
2. Set backup.framework.provider.plugin to nas
3. Create a Backup schedule by navigating to Storage --> Backup Schedule

What to do about it?

Reflect only time in the time field, currently it looks like day of week for the weekly and day of the month for the monthly schedules is being included.

[daviftorres]

Hey @prashanthr2, I also noticed a couple of odd behaviors in ACS 4.20.1 when scheduling backups:

• Daily backup overwrite - If you schedule a DAILY backup at a certain time (e.g., 8:00 AM) and then schedule another one at a different time (e.g., 8:00 PM), the second one overwrites the first. Not sure if this is expected, since the Scheduled backups tab shows a list.

• Deletion issue - When you have multiple schedules, clicking ANY delete button doesn’t immediately remove the entry from the UI. However, after refreshing the page, the deleted ALL entries are gone.

[shwstppr]

@prashanthr2 I think the schedule format is inline with the documentation https://cloudstack.apache.org/api/apidocs-4.21/apis/createBackupSchedule.html

custom backup schedule, the format is:for HOURLY MM*, for DAILY MM:HH*, for WEEKLY MM:HH:DD (1-7)*, for MONTHLY MM:HH:DD (1-28)

can be a bit confusing though

[abh1sar]

The change is done on top of other improvements (ui and api) which were done in 4.21. So, I have created a PR to fix this in 4.22.1 instead of 4.20.3.

@daviftorres

Daily backup overwrite - If you schedule a DAILY backup at a certain time (e.g., 8:00 AM) and then schedule another one at a different time (e.g., 8:00 PM), the second one overwrites the first. Not sure if this is expected, since the Scheduled backups tab shows a list.

This is expected. Only one schedule can be created for an interval. To make this more intuitive, I have made a change so that the interval for which a schedule is already present is disabled in the UI similar to create recurring snapshots.

Deletion issue - When you have multiple schedules, clicking ANY delete button doesn’t immediately remove the entry from the UI. However, after refreshing the page, the deleted ALL entries are gone.

This has been fixed since 4.21.