From afa15ea4c3f4571204789415745a8db379d10b18 Mon Sep 17 00:00:00 2001 From: "Gary David Gregory (Code signing key)" Date: Mon, 15 Jan 2024 09:07:59 -0500 Subject: [PATCH] Use += --- src/main/java/org/apache/bcel/classfile/Utility.java | 2 +- src/main/java/org/apache/bcel/util/Class2HTML.java | 2 +- src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/bcel/classfile/Utility.java b/src/main/java/org/apache/bcel/classfile/Utility.java index 691577e06f..a860906872 100644 --- a/src/main/java/org/apache/bcel/classfile/Utility.java +++ b/src/main/java/org/apache/bcel/classfile/Utility.java @@ -1169,7 +1169,7 @@ public static String signatureToString(final String signature, final boolean cho type = typeParams + typeSignaturesToString(signature.substring(index), chopit, ')'); index += unwrap(CONSUMER_CHARS); // update position // add return type - type = type + typeSignatureToString(signature.substring(index), chopit); + type += typeSignatureToString(signature.substring(index), chopit); index += unwrap(CONSUMER_CHARS); // update position // ignore any throws information in the signature return type; diff --git a/src/main/java/org/apache/bcel/util/Class2HTML.java b/src/main/java/org/apache/bcel/util/Class2HTML.java index 13952db0a4..603b05fb91 100644 --- a/src/main/java/org/apache/bcel/util/Class2HTML.java +++ b/src/main/java/org/apache/bcel/util/Class2HTML.java @@ -85,7 +85,7 @@ public static void main(final String[] argv) throws IOException { if (argv[i].equals("-d")) { // Specify target directory, default '.' dir = argv[++i]; if (!dir.endsWith("" + sep)) { - dir = dir + sep; + dir += sep; } final File store = new File(dir); if (!store.isDirectory()) { diff --git a/src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java b/src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java index b9b94e2ffc..2d58c43e50 100644 --- a/src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java +++ b/src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java @@ -61,7 +61,7 @@ public class JvmOpCodes { * Tests {@link DUP2}. */ long dup2(long a) { - return a = a + 1; + return a++; } /**